Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Commit a0be5b9

Browse files
committed
finished ChoicePrompt tests; stripped whitespace from TestAdapter
1 parent 614b016 commit a0be5b9

File tree

4 files changed

+488
-38
lines changed

4 files changed

+488
-38
lines changed

libraries/botbuilder-core/botbuilder/core/adapters/test_adapter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ def default_inspector(reply, description=None):
207207
validate_activity(reply, expected)
208208
else:
209209
assert reply.type == 'message', description + f" type == {reply.type}"
210-
assert reply.text == expected, description + f" text == {reply.text}"
210+
assert reply.text.strip() == expected.strip(), description + f" text == {reply.text}"
211211

212212
if description is None:
213213
description = ''

libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/choice_prompt.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class ChoicePrompt(Prompt):
2020
By default the prompt will return to the calling dialog a `FoundChoice` object containing the choice that was selected.
2121
"""
2222
_default_choice_options: Dict[str, ChoiceFactoryOptions] = {
23-
Culture.English: ChoiceFactoryOptions(inline_separator = ', ', inline_or = ' o ', include_numbers = True),
23+
Culture.Spanish: ChoiceFactoryOptions(inline_separator = ', ', inline_or = ' o ', include_numbers = True),
2424
Culture.Dutch: ChoiceFactoryOptions(inline_separator = ', ', inline_or = ' of ', include_numbers = True),
2525
Culture.English: ChoiceFactoryOptions(inline_separator = ', ', inline_or = ' or ', include_numbers = True),
2626
Culture.French: ChoiceFactoryOptions(inline_separator = ', ', inline_or = ' ou ', include_numbers = True),

libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/prompt_options.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
11
# Copyright (c) Microsoft Corporation. All rights reserved.
22
# Licensed under the MIT License.
33

4+
from typing import List
5+
46
from botbuilder.schema import Activity
57
from botbuilder.dialogs.choices import Choice, ListStyle
68

79

810
class PromptOptions:
911

10-
def __init__(self, prompt: Activity = None, retry_prompt: Activity = None, choices: [Choice] = None, style: ListStyle = None, validations: object = None, number_of_attempts: int = 0):
12+
def __init__(self, prompt: Activity = None, retry_prompt: Activity = None, choices: List[Choice] = None, style: ListStyle = None, validations: object = None, number_of_attempts: int = 0):
1113
self.prompt= prompt
1214
self.retry_prompt= retry_prompt
1315
self.choices= choices

0 commit comments

Comments
 (0)