Skip to content

Commit 4c72153

Browse files
author
Eric Dahlvang
authored
Update comments in teams_helper (#531) (#533)
* change comments * black fix
1 parent a50715a commit 4c72153

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,6 @@ async def on_teams_members_removed_dispatch( # pylint: disable=unused-argument
412412
):
413413
teams_members_removed = []
414414
for member in members_removed:
415-
# TODO: fix this
416415
new_account_json = member.serialize()
417416
if "additional_properties" in new_account_json:
418417
del new_account_json["additional_properties"]

libraries/botbuilder-core/botbuilder/core/teams/teams_helper.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
import botbuilder.schema as schema
1111
import botbuilder.schema.teams as teams_schema
1212

13+
# Optimization: The dependencies dictionary could be cached here,
14+
# and shared between the two methods.
15+
1316

1417
def deserializer_helper(msrest_cls: Type[Model], dict_to_deserialize: dict) -> Model:
1518
dependencies = [
@@ -27,9 +30,6 @@ def deserializer_helper(msrest_cls: Type[Model], dict_to_deserialize: dict) -> M
2730
return deserializer(msrest_cls.__name__, dict_to_deserialize)
2831

2932

30-
# TODO consolidate these two methods
31-
32-
3333
def serializer_helper(object_to_serialize: Model) -> dict:
3434
if object_to_serialize is None:
3535
return None

0 commit comments

Comments
 (0)