Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4582] UserAssignedIdentity(WorkloadIdentity) auth fails with 'scope https://api.botframework.com is not valid' #4607

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4582

Description

This PR adds the /.default suffix to the scope for MSI authentication.

Specific Changes

  • Updated ManagedIdentityAuthenticator to add the suffix to the scope.

Testing

These images show the fix working with a bot deployed in AKS and another one deployed in an Azure App Service.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner January 22, 2024 15:25
@coveralls
Copy link

coveralls commented Jan 22, 2024

Pull Request Test Coverage Report for Build 7613456265

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 84.48%

Totals Coverage Status
Change from base Build 7587095843: 0.003%
Covered Lines: 20414
Relevant Lines: 22880

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 23c16dc into main Jan 24, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/msi-invalid-scope-error branch January 24, 2024 14:43
tracyboehrer pushed a commit that referenced this pull request Jan 24, 2024
…scope https://api.botframework.com is not valid' (#4607)

* Add scope post-fix in managedIdentityAuthenticator.

* Fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserAssignedIdentity(WorkloadIdentity) auth fails with 'scope https://api.botframework.com is not valid'
3 participants