Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle reactions added/removed separately #3796

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Jun 23, 2021

Fixes #3795

Description

Simple change for .NET parity. We just needed to allow reactions added and removed to both be handled.

Testing

image

@mdrichardson mdrichardson requested a review from a team as a code owner June 23, 2021 22:55
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you.

@coveralls
Copy link

coveralls commented Jun 23, 2021

Pull Request Test Coverage Report for Build 966058341

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 83.795%

Totals Coverage Status
Change from base Build 963000328: 0.005%
Covered Lines: 19494
Relevant Lines: 22039

💛 - Coveralls

@joshgummersall joshgummersall merged commit 29f86bb into microsoft:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS Activity Handler doesn't handle messageReactions for teams correctly
3 participants