Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds createChildContext method to ComponentDialog #1318

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

ltwlf
Copy link
Contributor

@ltwlf ltwlf commented Oct 16, 2019

Description

Add a createChildContext method ComponentDialog like in the dotnet implementation. There are cases where you need to create the child content from the outside and it makes the code cleaner and less redundant.

Specific Changes

  • Adds createChildContext method to ComponentDialog

@coveralls
Copy link

coveralls commented Oct 16, 2019

Pull Request Test Coverage Report for Build 84766

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 87.678%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/componentDialog.ts 9 11 81.82%
Totals Coverage Status
Change from base Build 84761: 0.03%
Covered Lines: 4912
Relevant Lines: 5389

💛 - Coveralls

Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit 1958ea6 into microsoft:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants