Skip to content

[BotBuilder][4.8] Compilation error due to different AppCredential used #1901

@Batta32

Description

@Batta32

Versions

What package version of the SDK are you using.
4.8.0 from MyGet
What nodejs version are you using
10.8.0
What browser version are you using
-
What os are you using
Windows 10

Describe the bug

Give a clear and concise description of what the bug is.
Using 4.8.0 of botbuilder's packages from MyGet, it throws a compilation's error.

This error shows up as AppCredentials of the method exchangeToken in BotFrameworkAdapter and ExtendedUserTokenProvider are different.

BotFrameworkAdapter uses AppCredentials from botframework-connector, howerver ExtendedUserTokenProvider uses AppCredentials from botbuilder-core.

image

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Give a clear and concise description of what you expected to happen.
The compilation of the botbuilder's packages should work correctly.

Screenshots

If applicable, add screenshots to help explain your problem.
image

Additional context

Add any other context about the problem here.
These changes are in master and in 4.8 branch

[bug]

Metadata

Metadata

Assignees

Labels

P0Must Fix. Release-blockerR8Release 8 - March 16th, 2020

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions