[PORT] [OAuth] small oauth fix

[tomlm]

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3333

The existing overload of GetOauthSignInLinkAsync function with a userId as argument isn't working. It was hardcoding directline, passing empty conversations etc. This PR is to fix that.

Changed projects

• Microsoft.Bot.Builder

[Stevenic]

Needs port

[mdrichardson]

@cleemullins @Stevenic

I don't believe this needs a port. This particular fix addresses one of the C# overloads (there are 3 overloads + the original. Note the userId argument):

public virtual async Task<string> GetOauthSignInLinkAsync(ITurnContext turnContext, AppCredentials oAuthAppCredentials, string connectionName, string userId, string finalRedirect = null, CancellationToken cancellationToken = default)

The node version only has a single function (no overloads), which doesn't accept userId as an argument:

public async getSignInLink(context: TurnContext, connectionName: string): Promise<string> {

Do we want to close this or do you want me to add the overloads to Node?

[mdrichardson]

@cleemullins Disregard previous message. I see a couple of PRs that add additional overloads. I'll write up a PR that adds an overload that accepts userId, unless you have any objections.

@carlosscastro Thoughts?