From 433199b667c4bf8e671c5d4b0c8ae0fc843c2650 Mon Sep 17 00:00:00 2001 From: swagat mishra Date: Wed, 19 Feb 2020 01:53:31 -0800 Subject: [PATCH] mostly final changes before pr --- libraries/botbuilder-core/src/activityHandler.ts | 12 ++++++++++++ .../botbuilder-dialogs/src/prompts/oauthPrompt.ts | 10 +++++++--- package.json | 2 +- 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/libraries/botbuilder-core/src/activityHandler.ts b/libraries/botbuilder-core/src/activityHandler.ts index 842311668f..88a725ab87 100644 --- a/libraries/botbuilder-core/src/activityHandler.ts +++ b/libraries/botbuilder-core/src/activityHandler.ts @@ -250,6 +250,18 @@ export class ActivityHandler extends ActivityHandlerBase { return this.on('Event', handler); } + /** + * Registers an activity event handler for the _invoke_ event, emitted for every incoming event activity. + * + * @param handler The event handler. + * + * @remarks + * Returns a reference to the [ActivityHandler](xref:botbuilder-core.ActivityHandler) object. + * + * To handle a `signin/verifyState` invoke event or `signin/tokenExchange`, use the + * [onInvokeActivity](xref:botbuilder-core.ActivityHandler.onInvokeActivity) sub-type + * event handler. To handle other named events, add logic to this handler. + */ public onInvoke(handler: BotHandler): this { return this.on('Invoke', handler); } diff --git a/libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts b/libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts index 4249fa62cf..0b0e010fc2 100644 --- a/libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts +++ b/libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts @@ -12,14 +12,18 @@ import { PromptOptions, PromptRecognizerResult, PromptValidator } from './promp import { channels } from '../choices/channel'; import { isSkillClaim } from './skillsHelpers'; -// documentation missing -class TokenExchangeInvokeRequest { +/** + * Request body accepted for a token exchange invoke activity. + */ +interface TokenExchangeInvokeRequest { id: string; connectionName: string; token: string; } -// documentation missing +/** + * Response body returned for a token exchange invoke activity. + */ class TokenExchangeInvokeResponse { id: string; connectionName: string; diff --git a/package.json b/package.json index 9ee1e0a431..37aa02f4f7 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "clean": "lerna run clean", "functional-test": "lerna run build && nyc mocha \"libraries/functional-tests/tests/*.test.js\"", "browser-functional-test": "cd libraries/browser-functional-tests && node nightwatch.js -e", - "test": "lerna run build && nyc mocha \"libraries/bot*/tests/**/ActivityHandler.test.js\"", + "test": "lerna run build && nyc mocha \"libraries/bot*/tests/**/*.test.js\"", "test:coveralls": "lerna run build && nyc mocha \"libraries/bot*/tests/**/*.test.js\" && nyc report --reporter=text-lcov | coveralls", "test-coverage": "nyc mocha \"libraries/bot*/tests/**/*.test.js\"", "upload-coverage": "nyc report --reporter=text-lcov | coveralls",