Skip to content

Commit 3aea9c0

Browse files
DDEfromORstevengum
authored andcommitted
Don't await for the duration of websocket sessions. (#1412)
1 parent d2d81d1 commit 3aea9c0

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

libraries/botbuilder/src/botFrameworkAdapter.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1179,8 +1179,9 @@ export class BotFrameworkAdapter extends BotAdapter implements IUserTokenProvide
11791179

11801180
const upgrade = (res as any).claimUpgrade();
11811181
const socket = this.webSocketFactory.createWebSocket(req as IncomingMessage, upgrade.socket, upgrade.head);
1182+
this.startWebSocket(socket);
11821183

1183-
await this.startWebSocket(socket);
1184+
return;
11841185
}
11851186

11861187
private async authenticateConnection(req: WebRequest, channelService?: string): Promise<void> {
@@ -1205,9 +1206,9 @@ export class BotFrameworkAdapter extends BotAdapter implements IUserTokenProvide
12051206
* Connects the handler to a WebSocket server and begins listening for incoming requests.
12061207
* @param socket The socket to use when creating the server.
12071208
*/
1208-
private async startWebSocket(socket: ISocket): Promise<void>{
1209+
private startWebSocket(socket: ISocket): void{
12091210
this.streamingServer = new WebSocketServer(socket, this);
1210-
await this.streamingServer.start();
1211+
this.streamingServer.start();
12111212
}
12121213

12131214
private async readRequestBodyAsString(request: IReceiveRequest): Promise<Activity> {

0 commit comments

Comments
 (0)