[Webpack][ISSUE#818][BotBuilder-AI][BF-Connector] Fix webpack dependency warning (#1540)

* Add getFetch function and tests to botbuilder-ai

* Add setGlobals function and tests to bf-connector

* Update getFetch function

* Update set globals apis from bf-connector

* Add Copyright header to BF-Connector index file

* Update global functions to set fetch and formData

* Remove dom from botbuilder-ai tsconfig

* Add Copyright header

Co-authored-by: Steven Ickman <stevenic@microsoft.com>
Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>

Author: 3 people

libraries/botbuilder-ai/src/custom.window.ts

@@ -0,0 +1,13 @@
+/**
+ * @module botbuilder-ai
+ */
+/**
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License.
+ */
+
+declare global {
+    interface Window {}
+}
+
+export interface window extends Window {}

libraries/botbuilder-ai/src/globals.ts

@@ -0,0 +1,19 @@
+/* eslint-disable @typescript-eslint/explicit-function-return-type */
+/**
+ * @module botbuilder
+ */
+/**
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License.
+ */
+
+const window = require('./custom.window');
+
+export function getFetch() {    
+    const env = (global || window) as any;
+
+    if (!env.hasOwnProperty('fetch')) {    
+        env.fetch = require('node-fetch');
+    }
+    return env.fetch;
+}

libraries/botbuilder-ai/src/qnamaker-utils/httpRequestUtils.ts

@@ -8,10 +8,12 @@
 
 import * as os from 'os';
 const pjson: any = require('../../package.json');
-const request = (new Function('require', 'if (!this.hasOwnProperty("fetch")) { return require("node-fetch"); } else { return this.fetch; }'))(require);
 
 import { QnAMakerEndpoint } from '../qnamaker-interfaces/qnamakerEndpoint';
 
+import { getFetch } from '../globals';
+const fetch = getFetch();
+
 /**
  * Http request utils class.
  *
@@ -43,7 +45,7 @@ export class HttpRequestUtils {
 
         const headers: any = this.getHeaders(endpoint);
 
-        const qnaResult: any = await request(requestUrl, {
+        const qnaResult: any = await fetch(requestUrl, {
             method: 'POST',
             headers: headers,
             timeout: timeout,

libraries/botbuilder-ai/tests/qnaMaker.test.js

@@ -4,6 +4,7 @@ const { TestAdapter, TurnContext, NullTelemetryClient } = require('botbuilder-co
 const { QnAMaker } = require('../');
 const nock = require('nock');
 const fs = require('fs');
+const { getFetch } = require('../lib/globals');
 
 // Save test keys
 const knowledgeBaseId = process.env.QNAKNOWLEDGEBASEID;
@@ -747,6 +748,25 @@ describe('QnAMaker', function () {
             assert.strictEqual(qnaResults, descendingQnaResults, 'answers should be sorted from greatest to least score');
         });
     });
+
+    describe('getFetch()', function(){    
+
+        it('Should return fetch instance from global', function(){            
+            global.fetch = function() { return 'global fetch fake'; };
+
+            const fetch = getFetch();
+            assert.strictEqual('global fetch fake', fetch());   
+        });
+
+        it('Should set fetch API if it does not exist', function(){
+            if (global.fetch) {
+                delete global['fetch'];
+            }
+
+            const fetch = getFetch();
+            assert(typeof fetch === 'function');
+        });
+    });
 });
 
 class overrideTwoEventsWithOverrideLogger extends QnAMaker

libraries/botframework-connector/src/globals.ts

@@ -0,0 +1,22 @@
+/**
+ * @module botbuilder
+ */
+/**
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License.
+ */
+
+// set FormData and Fetch as global functions
+function setGlobals() {
+    const env = (global || window) as any;
+    
+    if (!env.hasOwnProperty("FormData")) { 
+        env.FormData = require("form-data");
+    }
+
+    if (!env.hasOwnProperty("fetch")) {
+        env.fetch = require("node-fetch");
+    }
+}
+
+setGlobals();

libraries/botframework-connector/src/index.ts

@@ -1,6 +1,13 @@
-(new Function('require', 'if (!this.hasOwnProperty("FormData")) { this.FormData = require("form-data"); }; if (!this.hasOwnProperty("fetch")) { this.fetch = require("node-fetch"); }'))(require);
+/**
+ * @module botbuilder
+ */
+/**
+ * Copyright (c) Microsoft Corporation. All rights reserved.
+ * Licensed under the MIT License.
+ */
 
 import { TokenResponse } from './connectorApi/models/mappers';
+import './globals'
 
 /**
  * @module botbuilder

libraries/botframework-connector/tests/connector.test.js

@@ -596,3 +596,15 @@ describe('Bot Framework Connector SDK', function() {
         });
     });
 });
+
+describe('setGlobals()', function(){
+
+    before(function(){
+        require('../lib/globals');
+    });
+
+    it('Should return fetch and FormData as global functions',async function(){             
+        assert(typeof global.fetch === 'function');
+        assert(typeof global.FormData === 'function');
+    });
+});