Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

fix: [#6697] Typing middleware not working as expected in teams as well as web chat channel#6743

Merged
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/show-typing-indicator
Feb 5, 2024
Merged

fix: [#6697] Typing middleware not working as expected in teams as well as web chat channel#6743
tracyboehrer merged 1 commit into
mainfrom
southworks/fix/show-typing-indicator

Conversation

@JhontSouth
Copy link
Copy Markdown
Collaborator

@JhontSouth JhontSouth commented Feb 2, 2024 •
edited
Loading

Fixes #6697

Description

This PR allows showing the typing indicator before every message bot.

Specific Changes

  • Added ProcessTypingAsync method in ShowTypingMiddleware class.
  • Added StartTyping process to every activity iteration in the OnSendActivities method execution.

Testing

The following image shows the typing indicator being displayed between the different messages sent by the bot.
image

@JhontSouth JhontSouth requested a review from a team as a code owner February 2, 2024 17:05
@JhontSouth JhontSouth added the Automation: No parity PR does not need to be applied to other languages. label Feb 2, 2024
@JhontSouth JhontSouth changed the title fix: [#6697]Typing middleware not working as expected in teams as well as web chat channel fix: [#6697] Typing middleware not working as expected in teams as well as web chat channel Feb 2, 2024
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Feb 2, 2024

Pull Request Test Coverage Report for Build 384208

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 78.379%
Files with Coverage Reduction New Missed Lines %
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Builder/ShowTypingMiddleware.cs 7 89.39%
Totals Coverage Status
Change from base Build 384147: 0.001%
Covered Lines: 26174
Relevant Lines: 33394
💛 - Coveralls

@BruceHaley
Copy link
Copy Markdown
Contributor

BruceHaley commented Feb 2, 2024

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll

@tracyboehrer tracyboehrer merged commit 36927e1 into main Feb 5, 2024
@tracyboehrer tracyboehrer deleted the southworks/fix/show-typing-indicator branch February 5, 2024 15:29
tracyboehrer pushed a commit that referenced this pull request Feb 6, 2024
@JhontSouth
show typing indicator before every message (#6743)
5842e9d
@dependabot dependabot Bot mentioned this pull request Dec 21, 2025
Merged
This was referenced May 14, 2026
Closed
Closed
Closed
Open
Closed
Closed
Open
Closed
Closed
Open
Closed
Open
Closed
Closed
Closed
Open
Open
Open
Open
This was referenced May 14, 2026
Open
Open
Open
Open
Open
Closed
Open
Closed
Closed
Closed
Closed
Open
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typing middleware not working as expected in teams as well as web chat channel

4 participants

@JhontSouth @coveralls @BruceHaley @tracyboehrer