This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Add sendx5c parameter to Certificate factory class#6699
Merged
Conversation
tracyboehrer
approved these changes
Oct 11, 2023
Collaborator
Author
|
Converting to draft while reviewing #6694 |
Collaborator
Pull Request Test Coverage Report for Build 372341
💛 - Coveralls |
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll |
Collaborator
Author
|
Hi @tracyboehrer , we reverted the changes to CertificateServiceClientCredentialsFactory as they were addressed in #6694. We kept the changes to MsalAppCredentials and the new unit tests. |
This was referenced May 14, 2026
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR adds the
sendx5cparameter to the CertificateServiceClientCredentialsFactory and MsalAppCredentials classes.Specific Changes
sendx5cparameter to the CertificateServiceClientCredentialsFactory class into a new constructor.sendx5cparameter to the MsalAppCredentials class into a new constructor.Testing
This image shows the new tests passing.
