Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Support MeetingTabIconSurface in Meeting Notification API#6621

Merged
tracyboehrer merged 2 commits into
mainfrom
yingdu/visualIndicator
Apr 24, 2023
Merged

Support MeetingTabIconSurface in Meeting Notification API#6621
tracyboehrer merged 2 commits into
mainfrom
yingdu/visualIndicator

Conversation

@yingduyingdu
Copy link
Copy Markdown
Contributor

@yingduyingdu yingduyingdu commented Apr 18, 2023

Fixes #6622

Description

Support MeetingTabIconSurface in Meeting Notification API

Specific Changes

  • Support MeetingTabIconSurface
  • Update surface converter with MeetingTabIconSurface
  • Update unit test

Testing

Updated unit test TestSendMeetingNotificationAsync with an additional surface that surface type is MeetingTabIcon

@yingduyingdu yingduyingdu requested a review from a team as a code owner April 18, 2023 19:42
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 18, 2023

Pull Request Test Coverage Report for Build 348700

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 41 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.009%) to 79.096%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs 1 90.0%
/libraries/Microsoft.Bot.Schema/Converters/SurfaceConverter.cs 3 62.5%
/libraries/Microsoft.Bot.Builder/Teams/TeamsActivityExtensions.cs 4 78.26%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SetProperties.cs 5 68.75%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SetProperty.cs 6 62.5%
/libraries/Microsoft.Bot.Builder/TelemetryLoggerMiddleware.cs 22 71.24%
Totals Coverage Status
Change from base Build 344537: -0.009%
Covered Lines: 25828
Relevant Lines: 32654

💛 - Coveralls

@yingduyingdu
Copy link
Copy Markdown
Contributor Author

Pending on review from feature owner

Comment thread libraries/Microsoft.Bot.Schema/Teams/MeetingTabIconSurface.cs Outdated
Comment thread libraries/Microsoft.Bot.Schema/Teams/MeetingTabIconSurface.cs
@BruceHaley
Copy link
Copy Markdown
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@tracyboehrer tracyboehrer merged commit bb6a077 into main Apr 24, 2023
@tracyboehrer tracyboehrer deleted the yingdu/visualIndicator branch April 24, 2023 18:19
This was referenced May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support MeetingTabIconSurface in Meeting Notification API

6 participants