Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCR: Add ability to Add/View Http Headers #799

Closed
daveta opened this issue Jul 26, 2018 · 2 comments
Closed

DCR: Add ability to Add/View Http Headers #799

daveta opened this issue Jul 26, 2018 · 2 comments
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release.
Milestone

Comments

@daveta
Copy link
Contributor

daveta commented Jul 26, 2018

Currently, by-design, there isn't a way to get Http headers (both incoming from channel, or adding http headers outbound).

There have been a few cases (specifically around custom correlation id scenarios) to:

  • Inspect Http Headers coming in, and be able to access in Middleware components
  • Be able to add Http Headers when sending messages

For correlation/tracing, I believe this mostly goes away App Insights adopts an in-flight standard. However, current ETA is December, which may slide.

https://w3c.github.io/distributed-tracing/report-trace-context.html
microsoft/ApplicationInsights-dotnet-server#945

I'm filing this because I believe Stevenic mentioned this was requested before (not sure the scenario) and potential slippage in finalization of the standard.

@drub0y
Copy link
Contributor

drub0y commented Jul 26, 2018

⚠️ HTTP is just one possible transport and I would highly recommend we be very careful about leaking anything specific into the Bot Builder APIs that mention or expose HTTP'isms directly. ⚠️

At most you'd maybe shove something into the TurnContext::Services collection at the adapter level that downstream middleware could look for and be tolerant to not finding in case, somewhere down the line, we support other transports.

@vishwacsena vishwacsena added the backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. label Aug 8, 2018
@vishwacsena vishwacsena added this to the Future milestone Aug 8, 2018
@gabog
Copy link
Contributor

gabog commented May 18, 2020

Closing as part of R10 triage.

@gabog gabog closed this as completed May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release.
Projects
None yet
Development

No branches or pull requests

4 participants