Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitPullRequestSearchCriteria interface (and probably others) out of date #599

Open
deerware opened this issue Jun 14, 2024 · 1 comment
Open

Comments

@deerware
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch azure-devops-node-api@11.2.0 for the project I'm working on.

The GitPullRequestSearchCriteria interface seems to be out of date.

Here is the diff that solved my problem. queryTimeRangeType enum is not specified, just a quick workaround so I can get working.

diff --git a/node_modules/azure-devops-node-api/interfaces/GitInterfaces.d.ts b/node_modules/azure-devops-node-api/interfaces/GitInterfaces.d.ts
index 817e555..0e19174 100644
--- a/node_modules/azure-devops-node-api/interfaces/GitInterfaces.d.ts
+++ b/node_modules/azure-devops-node-api/interfaces/GitInterfaces.d.ts
@@ -1862,6 +1862,18 @@ export interface GitPullRequestSearchCriteria {
      * Whether to include the _links field on the shallow references
      */
     includeLinks?: boolean;
+    /**
+     * If specified, filters pull requests that created/closed before this date based on the queryTimeRangeType specified.
+     */
+    maxTime?: Date;
+    /**
+     * If specified, filters pull requests that created/closed after this date based on the queryTimeRangeType specified.
+     */
+    minTime?: Date;
+    /**
+     * The type of time range which should be used for minTime and maxTime. Defaults to Created if unset.
+     */
+    queryTimeRangeType?: 'created' | 'closed';
     /**
      * If set, search for pull requests whose target branch is in this repository.
      */

This issue body was partially generated by patch-package.

@vmapetr
Copy link
Contributor

vmapetr commented Jul 26, 2024

Hi @deerware thanks for reporting!
We are working on more prioritized issues at the moment, but will get back to this one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants