Skip to content

Commit

Permalink
Disable proxy for NTLM authentication (#57)
Browse files Browse the repository at this point in the history
* Allow NTLM handler to disable proxying

* Bump version to 5.1.1
  • Loading branch information
Jeff Young authored and bryanmacfarlane committed Oct 21, 2016
1 parent d14dbe2 commit 04dc9f5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions api/handlers/ntlm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ export class NtlmCredentialHandler implements VsoBaseInterfaces.IRequestHandler

prepareRequest(options:any): void {
// No headers or options need to be set. We keep the credentials on the handler itself.
// If a (proxy) agent is set, remove it as we don't support proxy for NTLM at this time
if (options.agent) {
delete options.agent;
}
}

canHandleAuthentication(res: VsoBaseInterfaces.IHttpResponse): boolean {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vso-node-api",
"description": "Node client for Visual Studio Online/TFS REST APIs",
"version": "5.1.0",
"version": "5.1.1",
"main": "./WebApi.js",
"typings": "./WebApi.d.ts",
"scripts": {
Expand Down

0 comments on commit 04dc9f5

Please sign in to comment.