Skip to content

fix: McpToolAdapter : _run : ExceptionGroup #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

fix: McpToolAdapter : _run : ExceptionGroup #6458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/packages/autogen-ext/src/autogen_ext/tools/mcp/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,10 @@ async def _run(self, args: Dict[str, Any], cancellation_token: CancellationToken
if result.isError:
raise Exception(f"MCP tool execution failed: {result.content}")
return result.content
except Exception as e:
error_message = self._format_errors(e)
raise Exception(error_message) from e
except ExceptionGroup as eg:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why we don't use ExceptionGroup is because it is only available after Python 3.11

# Construct a message with all nested exception messages and args
exception_msg = "\n".join([f"{e.__class__.__name__}: {str(e)}\n{e.args}" for e in eg.exceptions])
raise Exception(exception_msg) from eg

@classmethod
async def from_server_params(cls, server_params: TServerParams, tool_name: str) -> "McpToolAdapter[TServerParams]":
Expand Down