Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utf-8 encoding at subprocess.run() #3454

Conversation

giorgossideris
Copy link
Contributor

Use utf-8 encoding for local code execution

Closes #3453

Checks

@giorgossideris giorgossideris marked this pull request as draft August 30, 2024 11:58
@giorgossideris giorgossideris marked this pull request as ready for review August 30, 2024 11:58
@Hk669
Copy link
Contributor

Hk669 commented Aug 30, 2024

@giorgossideris thanks for the fix.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.46%. Comparing base (6279247) to head (a1a5dd5).
Report is 128 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3454      +/-   ##
==========================================
+ Coverage   32.90%   37.46%   +4.55%     
==========================================
  Files          94       96       +2     
  Lines       10235    10979     +744     
  Branches     2193     2534     +341     
==========================================
+ Hits         3368     4113     +745     
+ Misses       6580     6493      -87     
- Partials      287      373      +86     
Flag Coverage Δ
unittest 11.94% <ø> (?)
unittests 37.41% <ø> (+4.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LocalCommandLineCodeExecutor decode error
4 participants