Performance Optimization for Foundation Build Pipeline: Break down build and test stage per platform by haonanttt · Pull Request #5363 · microsoft/WindowsAppSDK

haonanttt · 2025-04-25T02:58:35Z

Original "Build" stage run x86, x64 and arm64 together. "Test" stage will start when all build finished.

This PR break down the "Build" stage and "Test" stage into platform specific stages. For each platform, test will only depend on specific platform's build - Test_x86 will only depend on Build_x86, etc.

//////////////
A microsoft employee must use /azp run to validate using the pipelines below.

WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.

For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.

haonanttt · 2025-04-25T06:31:22Z

/azp run

azure-pipelines · 2025-04-25T06:31:39Z

Azure Pipelines successfully started running 1 pipeline(s).

…DK-Build-Per-Platform-Stage.yml

haonanttt · 2025-04-25T06:40:53Z

/azp run

azure-pipelines · 2025-04-25T06:41:30Z

Azure Pipelines successfully started running 1 pipeline(s).

haonanttt · 2025-04-25T08:58:37Z

/azp run

azure-pipelines · 2025-04-25T08:59:15Z

Azure Pipelines successfully started running 1 pipeline(s).

haonanttt · 2025-04-27T06:50:46Z

/azp run

azure-pipelines · 2025-04-27T06:51:01Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR optimizes the build pipeline by breaking down the build and test stages into platform‐specific jobs, ensuring test jobs only run after their corresponding build stage has succeeded. Key changes include:

Injecting a test matrix parameter into multiple YAML definitions.
Splitting the unified test stage into Test_x86, Test_x64, and Test_arm64 stages.
Introducing a new build-per-platform template that replaces portions of the existing build stage.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
build/WindowsAppSDK-Foundation-PR.yml	Injects testMatrix parameter for test stage configuration.
build/WindowsAppSDK-Foundation-Official.yml	Passes testMatrix parameter to the test stage.
build/WindowsAppSDK-Foundation-Nightly.yml	Passes testMatrix parameter to the test stage.
build/ProjectReunion-BuildFoundation.yml	Adds testMatrix parameter for platform-specific testing.
build/AzurePipelinesTemplates/WindowsAppSDK-Test-Stage.yml	Splits the Test stage into three platform-specific stages using the new parameter.
build/AzurePipelinesTemplates/WindowsAppSDK-RunTestsInPipeline-Job.yml	Updates the test job to use a filtered testMatrix keyed by platform.
build/AzurePipelinesTemplates/WindowsAppSDK-Publish-Stage.yml	Adjusts dependencies to account for the new test stage splits.
build/AzurePipelinesTemplates/WindowsAppSDK-PackTransportPackage-Stage.yml	Updates build dependencies to include new build stage names.
build/AzurePipelinesTemplates/WindowsAppSDK-Build-Stage.yml	Transitions build jobs to use the new per-platform build template.
build/AzurePipelinesTemplates/WindowsAppSDK-Build-Per-Platform-Stage.yml	New template that defines build stages per platform with associated parameters.

Comments suppressed due to low confidence (2)

build/AzurePipelinesTemplates/WindowsAppSDK-Build-Per-Platform-Stage.yml:16

[nitpick] Ensure that the generated stage name using 'Build_{buildPlatform}' is consistent with all other pipeline references and related documentation for clarity.

stage: ${{ format('Build_{0}', parameters.buildPlatform) }}

build/AzurePipelinesTemplates/WindowsAppSDK-Build-Stage.yml:67

Verify whether legacy job definitions (e.g. BuildFoundation_release_anycpu) are still required after transitioning to the new per-platform build template. Removing redundant jobs can help avoid duplicate builds.

# extract BuildFoundation and BuildMRT into WindowsAppSDK-Build-Stage-Per-Platform.yml.

Copilot · 2025-04-29T08:25:52Z

+  dependsOn: FilterMatrix
  strategy:
-    matrix: ${{ parameters.testMatrix }}
+    matrix: $[ dependencies.FilterMatrix.outputs['setFilteredMatrixStep.filteredMatrixJson'] ]


Ensure that the JSON output from the FilterMatrix step is correctly parsed as an object for the matrix. If the value is a JSON string, consider converting it to the proper object type so that the downstream job receives the expected structure.

Suggested change

matrix: $[ dependencies.FilterMatrix.outputs['setFilteredMatrixStep.filteredMatrixJson'] ]

matrix: $[ fromJson(dependencies.FilterMatrix.outputs['setFilteredMatrixStep.filteredMatrixJson']) ]

haonanttt · 2025-04-29T08:34:42Z

pipeline example runs:

yeelam-gordon

Looks good overall.
This one will make the pipeline more resumable.
And with Muyuan's #5364, the performance is better.

yeelam-gordon · 2025-04-29T10:22:55Z

-        md "C:\__t\NativeCompilerPrefast"
-      displayName: 'Creating C:\__t\NativeCompilerPrefast to prevent errors from Guardian PREfast'
-
  - job: BuildFoundation_release_anycpu


Do you know what is this for int the past? Looks like no consumer for this result afterwards?

I think the reason is that we wanted to build Microsoft.WindowsAppRuntime.Bootstrap.Net.csproj in AnyCPU.

It does seem like we have a consumer here

Copy-Item -path "BuildOutput\$configurationForMrtAndAnyCPU\anycpu\Microsoft.WindowsAppRuntime.Bootstrap.Net\Microsoft.WindowsAppRuntime.Bootstrap.Net.dll" -destination "$BasePath\lib\net6.0-windows10.0.17763.0"

in line 326 of
WindowsAppSDK\WindowsAppSDK\BuildAll.ps1

haonanttt · 2025-04-30T01:57:00Z

/azp run

azure-pipelines · 2025-04-30T01:57:15Z

Azure Pipelines successfully started running 1 pipeline(s).

Haonan Tang (from Dev Box) added 7 commits April 23, 2025 13:35

separate build per platform

023fec6

debug

2baca33

debug

157a19d

separate test per platform

ffeb5be

modify nightly and official pipeline

bce4627

specify pool for FilterMatrix job

a96b6bd

specify pool

0e52f02

microsoft-github-policy-service Bot added the needs-triage label Apr 25, 2025

haonanttt changed the base branch from user/hnmy/pipelineModify to main April 25, 2025 02:59

add comments

bb71b0e

haonanttt changed the title ~~User/haonanttt/test stage separation~~ Performance Optimization for Foundation Build Pipeline: Break down build and test stage per platform Apr 25, 2025

haonanttt requested a review from Hong-Xiang April 25, 2025 06:32

MuyuanMS reviewed Apr 25, 2025

View reviewed changes

Comment thread build/AzurePipelinesTemplates/WindowsAppSDK-Build-Stage.yml

rename yml file and pass runStaticAnalysis parameter into WindowsAppS…

10b03e5

…DK-Build-Per-Platform-Stage.yml

MuyuanMS reviewed Apr 25, 2025

View reviewed changes

Comment thread build/AzurePipelinesTemplates/WindowsAppSDK-Build-Stage-Per-Platform.yml

Comment thread build/AzurePipelinesTemplates/WindowsAppSDK-Build-Stage.yml Outdated

MuyuanMS reviewed Apr 25, 2025

View reviewed changes

Comment thread build/AzurePipelinesTemplates/WindowsAppSDK-Build-Stage.yml Outdated

update dependency for Build_AnyCPU

b8e0e96

Hong-Xiang reviewed Apr 27, 2025

View reviewed changes

Haonan Tang (from Dev Box) added 2 commits April 27, 2025 14:47

resolve comments

d57f095

modify empty line

c576f58

MuyuanMS approved these changes Apr 29, 2025

View reviewed changes

yeelam-gordon requested a review from Copilot April 29, 2025 08:24

yeelam-gordon requested a review from alexlamtest April 29, 2025 08:25

Copilot AI reviewed Apr 29, 2025

View reviewed changes

yeelam-gordon requested review from LegendaryBlair and kythant April 29, 2025 08:27

yeelam-gordon approved these changes Apr 29, 2025

View reviewed changes

kythant approved these changes Apr 29, 2025

View reviewed changes

renaming

4dccbb2

MuyuanMS approved these changes Apr 30, 2025

View reviewed changes

haonanttt merged commit 4e3e5ba into main Apr 30, 2025
30 checks passed

haonanttt deleted the user/haonanttt/testStageSeparation branch April 30, 2025 05:19

alexlamtest mentioned this pull request May 2, 2025

Pipeline Performance Optimization: Make Static Analysis Run Parallelly with Build #5364

Merged

	matrix: $[ dependencies.FilterMatrix.outputs['setFilteredMatrixStep.filteredMatrixJson'] ]
	matrix: $[ fromJson(dependencies.FilterMatrix.outputs['setFilteredMatrixStep.filteredMatrixJson']) ]

Conversation

haonanttt commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haonanttt commented Apr 25, 2025

Uh oh!

azure-pipelines Bot commented Apr 25, 2025

Uh oh!

Uh oh!

haonanttt commented Apr 25, 2025

Uh oh!

azure-pipelines Bot commented Apr 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haonanttt commented Apr 25, 2025

Uh oh!

azure-pipelines Bot commented Apr 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haonanttt commented Apr 27, 2025

Uh oh!

azure-pipelines Bot commented Apr 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

haonanttt commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yeelam-gordon left a comment

Choose a reason for hiding this comment

Uh oh!

yeelam-gordon Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

kythant Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

haonanttt commented Apr 30, 2025

Uh oh!

azure-pipelines Bot commented Apr 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

haonanttt commented Apr 25, 2025 •

edited

Loading

haonanttt commented Apr 29, 2025 •

edited

Loading