Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Pages should link to their folders on GitHub #413

Open
1 of 3 tasks
michael-hawker opened this issue Apr 23, 2020 · 5 comments
Open
1 of 3 tasks

Sample Pages should link to their folders on GitHub #413

michael-hawker opened this issue Apr 23, 2020 · 5 comments
Labels
enhancement Expand an existing sample or add feature to app sample enhancement Requests for new samples or changes to an existing page

Comments

@michael-hawker
Copy link
Contributor

michael-hawker commented Apr 23, 2020

Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?

  • New sample
  • Addition to existing sample
  • Modification to existing sample

If this is an addition/modification to an existing sample page, which one?
All Sample Pages

Additional context
There's a lot of samples that have additional code that's not always shown on the page, or helper classes. It'd be great if the Documentation section also provided a link to GitHub for that sample; so that it's easier to access and view those, since that code isn't always visible in the application.

E.g. the VariedImageSizeLayout.cs link for ItemsRepeater

@stmoy
Copy link
Contributor

stmoy commented Apr 23, 2020

We're closer to this via #392 but it sounds like even with that, there are pages that could use more links? Or do you think #392 gets us "close enough"?

Note that the fix mentioned above isn't in the store version yet. It's slated for the 2.4 release.

@michael-hawker
Copy link
Contributor Author

Thanks @stmoy, I must have missed the previous issue as it is closed now. #392 should be most of the way. I know for ItemsRepeater there are more 'helper' classes that are involved, so links to those would be useful. Maybe they are just links inline with the samples that they appear in? Not sure... 🤔

@marcelwgn
Copy link
Collaborator

I don't think that currently, there are samples where any helper code is not inside the page's code. The only items needed for the samples, that are not on the sample page are a few mock sample pages, which we use to show navigating.

@marcelwgn
Copy link
Collaborator

@michael-hawker Is there any specific controls besides ItemsRepeater where you would have expected more things to be linked?

@marcelwgn marcelwgn added the enhancement Expand an existing sample or add feature to app label Jun 25, 2022
@michael-hawker
Copy link
Contributor Author

@chingucoding I think it's for any helper in samples that's not bubbled up. For instance ItemsRepeater uses the ActivityFeedLayout but that's not shown how to get the code for that example anywhere: https://github.com/microsoft/WinUI-Gallery/blob/winui2/WinUIGallery/Common/ActivityFeedLayout.cs

@karkarl karkarl added the sample enhancement Requests for new samples or changes to an existing page label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Expand an existing sample or add feature to app sample enhancement Requests for new samples or changes to an existing page
Projects
None yet
Development

No branches or pull requests

4 participants