Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full text search #394

Open
MikeHillberg opened this issue Mar 30, 2020 · 4 comments
Open

Full text search #394

MikeHillberg opened this issue Mar 30, 2020 · 4 comments
Assignees
Labels
app enhancement Requests for general app improvements enhancement Expand an existing sample or add feature to app

Comments

@MikeHillberg
Copy link

The search feature only appears to search sample page names, not the page content. For example, to find sample code for FontIconSource, you have to know to search for SwipeControl.

It would be great to have an option to search the full text.

@marcelwgn
Copy link
Collaborator

This seems like a good idea, however I am not sure how we could implement this. After all, the search would need to be able to know the content of every page. What are your thoughts @stmoy?

Ideally, you wouldn't need to search for SwipeControl to find usage of FontIconSource but instead we would have a sample for it, though I am not entirely sure how that would work.

@stmoy
Copy link
Contributor

stmoy commented Jul 2, 2020

From a product point of view, I think this is a totally righteous ask - I'd love to have a richer search experience. From a technical point of view, I'm also not sure how to implement this 😅

Also agree that we should probably have a sample for FontIconSource. Perhaps this sample could live alongside samples for the other icon types which are also not well represented.

@ranjeshj
Copy link
Contributor

ranjeshj commented Sep 8, 2020

While searching all the content would be great that does make it a bit harder to achieve. A simpler task might be to add a list of search terms/tags to the json and match those in the search. That would atleast allow us to target specific results to show when searching. For example we can add search terms like StackLayout and UniformGridLayout to ItemsRepeater entry.

@marcelwgn marcelwgn added the enhancement Expand an existing sample or add feature to app label Jun 25, 2022
@karkarl karkarl added the app enhancement Requests for general app improvements label Feb 29, 2024
@AndrewKeepCoding
Copy link
Contributor

Something like this should work for page content search & highlighting.

image
RichTextBlockExtensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app enhancement Requests for general app improvements enhancement Expand an existing sample or add feature to app
Projects
Status: 📋 Backlog
Development

No branches or pull requests

6 participants