Draft: Initial rough ContainerManager #13650
Conversation
…oft/WSL into user/ptrivedi/wsla-service
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/src/shared/inc) | ||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/src/windows/inc) | ||
| include_directories(${CMAKE_CURRENT_BINARY_DIR}/src/windows/service/inc/${TARGET_PLATFORM}/${CMAKE_BUILD_TYPE}) | ||
| include_directories(${CMAKE_CURRENT_BINARY_DIR}/src/windows/wslaservice/inc/${TARGET_PLATFORM}/${CMAKE_BUILD_TYPE}) |
There was a problem hiding this comment.
This part of the diff is probably a result of being out of sync. Could you merge the latest feature/wsl-for-apps in this branch ? That should make the diff cleaner
| } | ||
|
|
||
| HRESULT WSLASession::GetDisplayName(LPWSTR* DisplayName) | ||
| WSLASession::WSLASession(const WSLA_SESSION_CONFIGURATION& SessionConfiguration) : m_sessionConfig(SessionConfiguration) |
There was a problem hiding this comment.
FYI this makes a copy of m_sessionConfig, but that structure has pointers that are only valid while the COM call is in progress so in the future we'll need to make a deep copy of that structure
ptrivedi
force-pushed
the
user/ptrivedi/cont-mgr
branch
from
48da027 to
7f91c00
Compare
|
|
||
| #include <filesystem> | ||
| #include "wslservice.h" | ||
| #include "wslaservice.h" |
There was a problem hiding this comment.
This change and other similar ones are probably an artifact of the previous merge. Those should be removed (it's preventing the CI from building)
ptrivedi
force-pushed
the
user/ptrivedi/cont-mgr
branch
from
7f91c00 to
c5c615d
Compare
|
|
||
| #include "WSLAVirtualMachine.h" | ||
|
|
||
| namespace wsl::windows::service::wsla { |
There was a problem hiding this comment.
In general we like our namespace names to match the file paths, so this would be wsl::windows::wslaservice
| }; | ||
|
|
||
| private: | ||
| WSLAVirtualMachine* m_pVM; |
There was a problem hiding this comment.
I worry a little bit about the lifetime of the VM class. The session is the owner of it, but also the owner of the container manager. Might be good to think about this relationship. Regardless, a raw c-style pointer is probably not the right data type since there's no guarantee around lifetime.
There was a problem hiding this comment.
Noted. This is just a placeholder for now, will need a revisit
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed