-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Distributions: Add Rocky Linux 9 and 10 #13094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@microsoft-github-policy-service agree |
craigloewen-msft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried the distro out and looks great to me. Thanks for doing the work to add this!! :)
|
Cool! |
|
Thank you for doing @lumarel. This looks good overall, but I want to point a couple things:
You can use validate-modern.py to validate that the extended attributes are supported by WSL1. Sample usage: Let me know what you'd like to do above those two, you get the final say as the distribution maintainer, but we definitely recommend fixing those before merging, since that will give your users a better experience. |
OneBlue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on maintainers to reply on above feedback
For what it's worth this is probably because I did this in Fedora (sorry) - it's now fixed there so if Rocky pulls the latest sources from Fedora Rawhide this particular issue will be addressed. |
|
Took me a long time to get back on this (sorry, work ate my time) I will get that sorted out hopefully very soon. |
Summary of the Pull Request
This PR will add Rocky Linux as a new distribution to the DistributionInfo.json list. More specifically the releases of 9.6 and 10.0.
The WSL images are hosted on the main CDN of the project and I made sure with releng that the links should not break in the future, even if the content is moved to the vault.
Further these images are built with KIWI-ng with these recipes: 9 and 10
And finally I looked at the PR for Fedora and hopefully checked everything that might be necessary, if there is anything I/we might be able to improve I'm sure going to do so! 🙂
(beside updating the image when we build a new version of course in the future)
Cheers, Lukas
PR Checklist