Fix Mac installer issues #1212
Merged
Fix Mac installer issues #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamill
approved these changes
May 28, 2019
| KEXTPATH="/Library/Extensions/PrjFSKext.kext" | ||
| isKextLoadedCmd="/usr/sbin/kextstat -l -b $KEXTBUNDLEID | wc -l" | ||
| isKextLoaded=$(eval $isKextLoadedCmd) | ||
| if [ "$isKextLoaded" -eq 0 ]; then |
There was a problem hiding this comment.
Are there any error conditions we might have to account for here?
There was a problem hiding this comment.
kextstat can return console output which can indicate couple things
- macOS successfully auto-loaded our kext after install.
- there was a
kextstaterror.
Updated postflight to logkextstat output, in case it was a kextstat error.
| isKextLoaded=$(eval $isKextLoadedCmd) | ||
| if [ "$isKextLoaded" -eq 0 ]; then | ||
| loadCmd="/sbin/kextload \"$KEXTPATH\"" | ||
| echo $loadCmd |
There was a problem hiding this comment.
In other places, it looks like we include a little more context around the operation, rather than just the command. Should we do that here as well?
There was a problem hiding this comment.
Added a short comment with info on what we are trying to do.
alameenshah
changed the title
|
/azp run GitHub VFSForGit Mac Functional Tests |
|
No pipelines are associated with this pull request. |
jrbriggs
suggested changes
May 29, 2019
Mac installer relies on GVFS.Service to do the auto-mount of registered repos. When GVFS.Service gets launched (post installation) it (Service) calls gvfs mount in the background (without user interaction). In this case if the kext is not loaded, then mount will fail. Updating the installer to load kext would help in scenario. Also updated postflight script to log output of kextstat command that is used to determine if macOS autoloaded kext or not. A non empty output means kext got autoloaded or there was an error running kextstat. Fixes #1210
jrbriggs
approved these changes
May 29, 2019
nickgra
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix couple installer issues
Mac installer relies on GVFS.Service to do the auto-mount of registered repos. When GVFS.Service gets launched (post installation) it (Service) calls gvfs mount in the background (without user interaction). In this case if the kext is not loaded, then mount will fail. Updating the installer to load kext would help in scenario. Also updated postflight script to log output of kextstat command that is used to determine if macOS autoloaded kext or not. A non empty output means kext got autoloaded or there was an error running kextstat.
Don't install copy of "VFS For Git.app" in /usr/loca/vfsforgit directory.
Fixes #1210