LibGit2RepoInvoker: Test a real SHA1 when initializing

derrickstolee · derrickstolee · commit 6e00a0f6cb0f · 2019-06-13T21:20:42.000-04:00
In order to force the LibGit2Repo to load the object store information
upon initialization, it does not suffice to use the empty SHA, as that
is short-cut somewhere and does not acheive the goals we want.

Signed-off-by: Derrick Stolee &lt;dstolee@microsoft.com&gt;
diff --git a/GVFS/GVFS.Common/Git/LibGit2RepoInvoker.cs b/GVFS/GVFS.Common/Git/LibGit2RepoInvoker.cs
@@ -77,7 +77,9 @@ public void InitializeSharedRepo()
         {
             // Run a test on the shared repo to ensure the object store
             // is loaded, as that is what takes a long time with many packs.
-            this.GetSharedRepo()?.ObjectExists(GVFSConstants.AllZeroSha);
+            // Using a potentially-real object id is important, as the empty
+            // SHA will stop early instead of loading the object store.
+            this.GetSharedRepo()?.ObjectExists("30380be3963a75e4a34e10726795d644659e1129");
         }
 
         private LibGit2Repo GetSharedRepo()

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,9 @@ public void InitializeSharedRepo()`
`77`	`77`	`{`
`78`	`78`	`// Run a test on the shared repo to ensure the object store`
`79`	`79`	`// is loaded, as that is what takes a long time with many packs.`
`80`		`- this.GetSharedRepo()?.ObjectExists(GVFSConstants.AllZeroSha);`
	`80`	`+ // Using a potentially-real object id is important, as the empty`
	`81`	`+ // SHA will stop early instead of loading the object store.`
	`82`	`+ this.GetSharedRepo()?.ObjectExists("30380be3963a75e4a34e10726795d644659e1129");`
`81`	`83`	`}`
`82`	`84`
`83`	`85`	`private LibGit2Repo GetSharedRepo()`