Skip to content

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Aug 15, 2024

This simplifies things, and lets us dogfood the experience.

$  hyperfine -w 3 -n 'before' -p 'git switch main' 'node ./node_modules/eslint/bin/eslint.js .' -n 'after' -p 'git switch eslint-project-service' 'node ./node_modules/eslint/bin/eslint.js .'
Benchmark 1: before
  Time (mean ± σ):     26.980 s ±  0.523 s    [User: 42.924 s, System: 1.743 s]
  Range (min … max):   26.235 s … 28.133 s    10 runs

Benchmark 2: after
  Time (mean ± σ):     27.924 s ±  0.322 s    [User: 44.788 s, System: 1.784 s]
  Range (min … max):   27.451 s … 28.619 s    10 runs

Summary
  'before' ran
    1.04 ± 0.02 times faster than 'after'

Slower, but we also have technically enabled typed linting on a handful of new files?

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 15, 2024
@jakebailey jakebailey marked this pull request as ready for review August 15, 2024 20:19
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Aug 16, 2024

Slower, but we also have technically enabled typed linting on a handful of new files?

What would a more apples-to-apples comparison look like with the same rules?

@jakebailey
Copy link
Member Author

I would just ignore the three root files altogether, then compare before and after.

But, those files are small, so I would think the culprit here is actually #59335.

@jakebailey jakebailey marked this pull request as draft August 30, 2024 20:10
@jakebailey jakebailey closed this Apr 1, 2025
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants