Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark prototype property of constructors as readonly in DOM types #59529

Closed

Conversation

petamoriken
Copy link
Contributor

In DOM types, the PR is in progress to mark prototype property of constructors as readonly. This PR was created to see if the CI test would pass.

We nowadays have better testing and hopefully the CI in microsoft/TypeScript side repo can catch potential breakage @orta was talking about on DefinitelyTyped. PR welcome (assuming one would also try the CI on TS repo too)

microsoft/TypeScript-DOM-lib-generator#968 (comment)

@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 3, 2024
@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TypeScript-DOM-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed.

@jakebailey
Copy link
Member

Sorry, the bot auto closes PRs from non-maintainers touching these generated files as they're typically sent by people who want to do other changes and don't realize the files are generated. (Not true in your case.)

However, do note that this change is in direct opposition to changes made in #58296 which may actually require these prototypes to lose the readonly modifier.

@petamoriken petamoriken deleted the feat/readonly-prototype-dom branch August 3, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants