Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #57896 #58857

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Revert #57896 #58857

merged 2 commits into from
Jun 13, 2024

Conversation

andrewbranch
Copy link
Member

My attempt (#58831) to just disable #57896 was incomplete, so this is the full revert instead.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 13, 2024
@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@jakebailey
Copy link
Member

Does this also undo Wesley's change? Or does that still work?

@andrewbranch
Copy link
Member Author

The only interaction between my work and #58176 is how often package.jsons that one of us is doing a lookup for is already cached because of a lookup that the other is doing.

@andrewbranch
Copy link
Member Author

@typescript-bot cherry-pick to release-5.5

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 13, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick to release-5.5 ✅ Started ❌ Results

@typescript-bot
Copy link
Collaborator

Hey, @andrewbranch! I was unable to cherry-pick this PR.

Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/9508013806

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@andrewbranch andrewbranch merged commit 5628973 into microsoft:main Jun 13, 2024
28 checks passed
@andrewbranch andrewbranch deleted the revert-57896 branch June 13, 2024 23:40
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.5.2 milestone Jun 14, 2024
DanielRosenwasser pushed a commit that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants