Bump TS devDep to 5.3, hack dtsBundler to remove new comments

[jakebailey]

The package-lock bumper is failing because it sees that tests fail after updating deps.

This was caused by #50097 which started emitting more comments. Since our dts bundler is very naive and just prints nodes as-is, this means that we'll include non-JSDoc comments too, which isn't super desirable.

This turns out to probably not be super great for dts emit; see the dts emit here: Playground Link

For now, I've just used internal APIs to override the comment writing function to avoid emitting // comments entirely, which lets us bump TS. Thankfully, I chose to dprint the output of the bundler, so the hack doesn't cause a diff due to stray spaces left in after my hack.

Probably we should be figuring out if dts emit should even output these kinds of comments, and also if the printing system should let you disable the emitting of non-jsdoc comments. That or I've missed something and that other PR was just wrong.

[sandersn]

wow, that is hacky!

[sandersn]

this reminds me that we devdep on playwright =(

[jakebailey]

It's not a big deal; as of 1.38 the package only depends on playwright-core (which is dependency free) and does not install browsers unless requested. The pair of packages is 2-3x smaller than the TypeScript package itself. I actually added this intentionally to simplify our builds once the change was made.

[fatcerberus]

and also if the printing system should let you disable the emitting of non-jsdoc comments

Sounds suspiciously like #38427

[jakebailey]

Funkily we already emitted some comments in places like parameter lists even in declaration emit, so this is nothing new: Playground Link

Since the dts bundler works off of the dts code that tsc emits, these comments are all actually appearing in the real dts files. The dts bundler does not actually run off of the original source at all.