Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve alias symbols on references to type aliases via imports #51152

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Preserve alias symbols on references to type aliases via imports #51152

merged 3 commits into from
Nov 18, 2022

Conversation

weswigham
Copy link
Member

Fixes #51106

Technically, we could always use the alias we're referring to as the alias symbol saved for an alias lookup, but that could be a lot of new type identities, and by limiting it to only cases where the type reference refers to an import alias, we capture the cases where referring to exactly the symbol exported is particularly important for reusing the imports/names the user has made available.

@weswigham
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Oct 12, 2022
@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 12, 2022 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at aa26036. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51152
Metric main 51152 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 352,840k (± 0.02%) 352,835k (± 0.02%) -5k (- 0.00%) 352,590k 352,987k
Parse Time 1.55s (± 0.32%) 1.55s (± 0.58%) +0.00s (+ 0.00%) 1.52s 1.57s
Bind Time 0.61s (± 0.77%) 0.61s (± 0.73%) +0.00s (+ 0.33%) 0.60s 0.62s
Check Time 4.40s (± 0.72%) 4.39s (± 0.32%) -0.02s (- 0.36%) 4.35s 4.42s
Emit Time 4.94s (± 0.67%) 4.90s (± 0.46%) -0.04s (- 0.87%) 4.85s 4.94s
Total Time 11.50s (± 0.57%) 11.44s (± 0.28%) -0.06s (- 0.50%) 11.39s 11.51s
Compiler-Unions - node (v18.10.0, x64)
Memory used 200,062k (± 0.84%) 200,542k (± 0.63%) +480k (+ 0.24%) 195,496k 201,370k
Parse Time 0.61s (± 0.78%) 0.61s (± 0.98%) -0.00s (- 0.16%) 0.60s 0.62s
Bind Time 0.36s (± 0.62%) 0.36s (± 1.30%) +0.00s (+ 0.28%) 0.35s 0.37s
Check Time 5.38s (± 0.41%) 5.39s (± 0.69%) +0.02s (+ 0.35%) 5.31s 5.52s
Emit Time 1.82s (± 0.80%) 1.83s (± 1.04%) +0.00s (+ 0.22%) 1.80s 1.89s
Total Time 8.17s (± 0.32%) 8.19s (± 0.69%) +0.02s (+ 0.27%) 8.10s 8.40s
Monaco - node (v18.10.0, x64)
Memory used 331,714k (± 0.02%) 331,723k (± 0.01%) +9k (+ 0.00%) 331,631k 331,854k
Parse Time 1.17s (± 0.51%) 1.17s (± 0.92%) +0.01s (+ 0.52%) 1.15s 1.20s
Bind Time 0.56s (± 1.00%) 0.56s (± 0.84%) +0.00s (+ 0.36%) 0.55s 0.57s
Check Time 4.29s (± 0.40%) 4.29s (± 0.88%) +0.00s (+ 0.02%) 4.21s 4.36s
Emit Time 2.61s (± 0.41%) 2.63s (± 0.57%) +0.02s (+ 0.76%) 2.59s 2.67s
Total Time 8.62s (± 0.31%) 8.65s (± 0.48%) +0.03s (+ 0.32%) 8.50s 8.71s
TFS - node (v18.10.0, x64)
Memory used 294,678k (± 0.01%) 294,687k (± 0.03%) +9k (+ 0.00%) 294,488k 294,834k
Parse Time 0.94s (± 0.78%) 0.94s (± 0.92%) -0.00s (- 0.00%) 0.92s 0.96s
Bind Time 0.59s (± 3.65%) 0.56s (± 1.54%) 🟩-0.03s (- 4.42%) 0.55s 0.58s
Check Time 4.01s (± 0.55%) 4.01s (± 0.50%) +0.01s (+ 0.12%) 3.98s 4.07s
Emit Time 2.62s (± 0.54%) 2.63s (± 0.93%) +0.01s (+ 0.23%) 2.58s 2.70s
Total Time 8.15s (± 0.47%) 8.14s (± 0.52%) -0.01s (- 0.17%) 8.05s 8.23s
material-ui - node (v18.10.0, x64)
Memory used 439,978k (± 0.01%) 439,960k (± 0.01%) -18k (- 0.00%) 439,876k 440,170k
Parse Time 1.35s (± 0.59%) 1.36s (± 1.63%) +0.01s (+ 1.04%) 1.34s 1.43s
Bind Time 0.44s (± 0.82%) 0.44s (± 1.31%) -0.00s (- 0.23%) 0.43s 0.46s
Check Time 10.86s (± 0.56%) 10.95s (± 0.64%) +0.09s (+ 0.84%) 10.83s 11.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.65s (± 0.54%) 12.76s (± 0.68%) +0.11s (+ 0.84%) 12.62s 12.91s
xstate - node (v18.10.0, x64)
Memory used 556,574k (± 0.01%) 556,758k (± 0.01%) +185k (+ 0.03%) 556,628k 556,949k
Parse Time 1.92s (± 0.47%) 1.91s (± 0.23%) -0.01s (- 0.36%) 1.90s 1.92s
Bind Time 0.68s (± 1.95%) 0.69s (± 1.83%) +0.01s (+ 1.17%) 0.67s 0.73s
Check Time 1.10s (± 0.69%) 1.11s (± 0.72%) +0.01s (+ 0.63%) 1.09s 1.13s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 3.76s (± 0.33%) 3.77s (± 0.45%) +0.01s (+ 0.19%) 3.73s 3.81s
Angular - node (v16.17.1, x64)
Memory used 352,334k (± 0.02%) 352,346k (± 0.01%) +12k (+ 0.00%) 352,204k 352,397k
Parse Time 1.89s (± 0.46%) 1.91s (± 1.05%) +0.02s (+ 1.06%) 1.88s 1.96s
Bind Time 0.74s (± 0.78%) 0.74s (± 0.46%) 0.00s ( 0.00%) 0.74s 0.75s
Check Time 5.69s (± 0.73%) 5.67s (± 0.40%) -0.02s (- 0.37%) 5.61s 5.73s
Emit Time 6.08s (± 0.66%) 6.07s (± 0.52%) -0.01s (- 0.18%) 5.99s 6.13s
Total Time 14.41s (± 0.57%) 14.40s (± 0.42%) -0.02s (- 0.12%) 14.21s 14.48s
Compiler-Unions - node (v16.17.1, x64)
Memory used 198,279k (± 0.57%) 197,201k (± 0.11%) -1,078k (- 0.54%) 196,332k 197,415k
Parse Time 0.79s (± 0.87%) 0.79s (± 0.60%) +0.00s (+ 0.25%) 0.78s 0.80s
Bind Time 0.45s (± 1.09%) 0.45s (± 0.75%) -0.00s (- 0.22%) 0.45s 0.46s
Check Time 6.50s (± 0.50%) 6.50s (± 0.51%) +0.00s (+ 0.03%) 6.44s 6.59s
Emit Time 2.31s (± 1.09%) 2.32s (± 0.76%) +0.01s (+ 0.43%) 2.28s 2.35s
Total Time 10.05s (± 0.50%) 10.06s (± 0.45%) +0.02s (+ 0.15%) 9.95s 10.18s
Monaco - node (v16.17.1, x64)
Memory used 331,133k (± 0.02%) 331,133k (± 0.01%) -0k (- 0.00%) 331,082k 331,183k
Parse Time 1.42s (± 0.37%) 1.43s (± 0.48%) +0.00s (+ 0.35%) 1.41s 1.44s
Bind Time 0.69s (± 0.86%) 0.69s (± 0.49%) -0.00s (- 0.14%) 0.69s 0.70s
Check Time 5.47s (± 0.55%) 5.47s (± 0.47%) -0.01s (- 0.13%) 5.43s 5.53s
Emit Time 3.26s (± 0.55%) 3.25s (± 0.69%) -0.01s (- 0.25%) 3.22s 3.33s
Total Time 10.85s (± 0.44%) 10.84s (± 0.39%) -0.01s (- 0.05%) 10.77s 10.96s
TFS - node (v16.17.1, x64)
Memory used 294,050k (± 0.02%) 294,115k (± 0.01%) +65k (+ 0.02%) 294,040k 294,178k
Parse Time 1.22s (± 1.53%) 1.24s (± 1.75%) +0.02s (+ 1.31%) 1.20s 1.30s
Bind Time 0.64s (± 0.97%) 0.64s (± 0.62%) +0.00s (+ 0.31%) 0.63s 0.65s
Check Time 5.12s (± 0.44%) 5.13s (± 0.50%) +0.01s (+ 0.12%) 5.07s 5.18s
Emit Time 3.47s (± 0.64%) 3.48s (± 0.41%) +0.01s (+ 0.26%) 3.45s 3.52s
Total Time 10.45s (± 0.42%) 10.49s (± 0.39%) +0.04s (+ 0.35%) 10.40s 10.55s
material-ui - node (v16.17.1, x64)
Memory used 439,350k (± 0.01%) 439,308k (± 0.01%) -42k (- 0.01%) 439,266k 439,383k
Parse Time 1.72s (± 1.24%) 1.72s (± 1.53%) +0.00s (+ 0.17%) 1.66s 1.76s
Bind Time 0.54s (± 0.69%) 0.54s (± 0.83%) +0.00s (+ 0.56%) 0.53s 0.55s
Check Time 12.52s (± 0.62%) 12.60s (± 0.73%) +0.08s (+ 0.61%) 12.43s 12.83s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.78s (± 0.53%) 14.86s (± 0.59%) +0.08s (+ 0.52%) 14.71s 15.07s
xstate - node (v16.17.1, x64)
Memory used 554,310k (± 0.02%) 554,551k (± 0.01%) +241k (+ 0.04%) 554,395k 554,785k
Parse Time 2.31s (± 0.28%) 2.31s (± 0.41%) -0.00s (- 0.04%) 2.29s 2.34s
Bind Time 0.89s (± 1.49%) 0.89s (± 2.09%) +0.00s (+ 0.11%) 0.87s 0.94s
Check Time 1.43s (± 0.92%) 1.42s (± 0.80%) -0.01s (- 0.42%) 1.39s 1.44s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 4.70s (± 0.23%) 4.69s (± 0.19%) -0.00s (- 0.11%) 4.67s 4.71s
Angular - node (v14.15.1, x64)
Memory used 346,620k (± 0.01%) 346,526k (± 0.08%) -94k (- 0.03%) 345,467k 346,725k
Parse Time 2.08s (± 1.31%) 2.07s (± 1.16%) -0.01s (- 0.53%) 2.03s 2.14s
Bind Time 0.80s (± 0.77%) 0.80s (± 0.56%) -0.00s (- 0.37%) 0.79s 0.81s
Check Time 5.99s (± 0.53%) 6.02s (± 0.77%) +0.02s (+ 0.40%) 5.94s 6.18s
Emit Time 6.33s (± 1.14%) 6.36s (± 1.04%) +0.02s (+ 0.38%) 6.22s 6.49s
Total Time 15.21s (± 0.60%) 15.24s (± 0.62%) +0.04s (+ 0.25%) 15.05s 15.53s
Compiler-Unions - node (v14.15.1, x64)
Memory used 190,802k (± 0.70%) 190,251k (± 0.01%) -551k (- 0.29%) 190,207k 190,292k
Parse Time 0.86s (± 0.88%) 0.86s (± 0.77%) +0.00s (+ 0.47%) 0.85s 0.88s
Bind Time 0.49s (± 0.96%) 0.49s (± 0.68%) +0.00s (+ 0.00%) 0.48s 0.50s
Check Time 6.80s (± 0.56%) 6.76s (± 0.60%) -0.04s (- 0.66%) 6.70s 6.89s
Emit Time 2.42s (± 0.78%) 2.44s (± 0.53%) +0.02s (+ 0.78%) 2.42s 2.48s
Total Time 10.57s (± 0.45%) 10.55s (± 0.44%) -0.03s (- 0.24%) 10.47s 10.68s
Monaco - node (v14.15.1, x64)
Memory used 326,600k (± 0.01%) 326,588k (± 0.01%) -12k (- 0.00%) 326,535k 326,641k
Parse Time 1.59s (± 0.75%) 1.58s (± 0.74%) -0.01s (- 0.57%) 1.56s 1.62s
Bind Time 0.73s (± 0.65%) 0.73s (± 0.76%) -0.00s (- 0.14%) 0.72s 0.75s
Check Time 5.78s (± 0.57%) 5.74s (± 0.38%) -0.03s (- 0.55%) 5.70s 5.78s
Emit Time 3.39s (± 0.79%) 3.40s (± 0.60%) +0.01s (+ 0.30%) 3.36s 3.44s
Total Time 11.48s (± 0.43%) 11.45s (± 0.37%) -0.03s (- 0.25%) 11.36s 11.53s
TFS - node (v14.15.1, x64)
Memory used 289,690k (± 0.01%) 289,715k (± 0.01%) +25k (+ 0.01%) 289,642k 289,788k
Parse Time 1.30s (± 0.63%) 1.30s (± 0.73%) -0.00s (- 0.23%) 1.28s 1.32s
Bind Time 0.80s (± 0.59%) 0.80s (± 1.13%) -0.00s (- 0.25%) 0.79s 0.83s
Check Time 5.41s (± 0.47%) 5.40s (± 0.25%) -0.01s (- 0.20%) 5.38s 5.44s
Emit Time 3.64s (± 0.84%) 3.61s (± 0.59%) -0.03s (- 0.88%) 3.56s 3.67s
Total Time 11.16s (± 0.33%) 11.11s (± 0.26%) -0.04s (- 0.39%) 11.05s 11.18s
material-ui - node (v14.15.1, x64)
Memory used 435,472k (± 0.01%) 435,477k (± 0.01%) +5k (+ 0.00%) 435,394k 435,532k
Parse Time 1.87s (± 0.48%) 1.87s (± 0.47%) -0.00s (- 0.27%) 1.85s 1.89s
Bind Time 0.58s (± 0.63%) 0.58s (± 0.58%) -0.00s (- 0.34%) 0.58s 0.59s
Check Time 12.90s (± 0.61%) 12.91s (± 1.35%) +0.01s (+ 0.06%) 12.75s 13.59s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.36s (± 0.55%) 15.37s (± 1.14%) +0.00s (+ 0.02%) 15.21s 16.05s
xstate - node (v14.15.1, x64)
Memory used 543,377k (± 0.01%) 543,562k (± 0.00%) +185k (+ 0.03%) 543,511k 543,610k
Parse Time 2.61s (± 0.56%) 2.60s (± 0.33%) -0.01s (- 0.34%) 2.59s 2.63s
Bind Time 0.99s (± 0.70%) 0.99s (± 1.16%) +0.01s (+ 0.81%) 0.97s 1.01s
Check Time 1.53s (± 0.61%) 1.53s (± 0.46%) +0.00s (+ 0.20%) 1.51s 1.54s
Emit Time 0.07s (± 0.00%) 0.07s (± 3.14%) +0.00s (+ 1.43%) 0.07s 0.08s
Total Time 5.20s (± 0.43%) 5.20s (± 0.30%) -0.00s (- 0.04%) 5.16s 5.23s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-126-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51152 10
Baseline main 10

TSServer

Comparison Report - main..51152
Metric main 51152 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,066ms (± 0.48%) 1,068ms (± 0.53%) +2ms (+ 0.20%) 1,056ms 1,081ms
Req 2 - geterr 2,723ms (± 0.55%) 2,724ms (± 0.67%) +1ms (+ 0.04%) 2,687ms 2,774ms
Req 3 - references 192ms (± 1.48%) 192ms (± 1.11%) +0ms (+ 0.05%) 187ms 196ms
Req 4 - navto 145ms (± 1.23%) 146ms (± 1.26%) +0ms (+ 0.14%) 142ms 151ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 44ms (± 1.86%) 44ms (± 1.13%) -1ms (- 1.80%) 43ms 45ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,134ms (± 0.73%) 1,136ms (± 0.75%) +2ms (+ 0.19%) 1,119ms 1,165ms
Req 2 - geterr 1,609ms (± 0.46%) 1,621ms (± 0.68%) +12ms (+ 0.74%) 1,594ms 1,639ms
Req 3 - references 198ms (± 0.93%) 198ms (± 0.35%) -0ms (- 0.15%) 196ms 199ms
Req 4 - navto 165ms (± 6.32%) 160ms (± 1.52%) 🟩-5ms (- 3.09%) 156ms 166ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 84ms (±11.88%) 88ms (± 4.09%) +4ms (+ 4.64%) 84ms 102ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,614ms (± 0.55%) 1,619ms (± 0.42%) +5ms (+ 0.33%) 1,607ms 1,639ms
Req 2 - geterr 585ms (± 0.39%) 587ms (± 0.38%) +3ms (+ 0.46%) 583ms 592ms
Req 3 - references 54ms (± 1.88%) 55ms (± 2.93%) +1ms (+ 2.43%) 53ms 61ms
Req 4 - navto 202ms (± 0.74%) 201ms (± 0.59%) -0ms (- 0.20%) 200ms 204ms
Req 5 - completionInfo count 3,206 (± 0.00%) 3,206 (± 0.00%) 0 ( 0.00%) 3,206 3,206
Req 5 - completionInfo 215ms (± 1.89%) 210ms (± 2.38%) -5ms (- 2.14%) 200ms 222ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,327ms (± 0.51%) 1,328ms (± 0.22%) +1ms (+ 0.08%) 1,323ms 1,336ms
Req 2 - geterr 3,303ms (± 0.63%) 3,346ms (± 1.52%) +43ms (+ 1.29%) 3,275ms 3,486ms
Req 3 - references 222ms (± 1.20%) 222ms (± 1.14%) -0ms (- 0.09%) 218ms 229ms
Req 4 - navto 158ms (± 1.04%) 156ms (± 0.55%) -2ms (- 1.08%) 155ms 158ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 68ms (±20.24%) 65ms (±21.09%) 🟩-4ms (- 5.43%) 52ms 96ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,406ms (± 0.55%) 1,406ms (± 0.58%) +1ms (+ 0.06%) 1,395ms 1,434ms
Req 2 - geterr 2,117ms (± 0.55%) 2,116ms (± 0.72%) -2ms (- 0.07%) 2,093ms 2,149ms
Req 3 - references 232ms (± 0.60%) 234ms (± 1.15%) +2ms (+ 0.86%) 229ms 239ms
Req 4 - navto 169ms (± 0.83%) 168ms (± 0.86%) -1ms (- 0.47%) 165ms 171ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 53ms (± 3.68%) 52ms (± 1.97%) -1ms (- 1.52%) 50ms 54ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,927ms (± 0.52%) 1,934ms (± 0.56%) +7ms (+ 0.38%) 1,915ms 1,959ms
Req 2 - geterr 737ms (± 0.59%) 744ms (± 0.40%) +6ms (+ 0.87%) 736ms 751ms
Req 3 - references 61ms (± 1.45%) 61ms (± 1.12%) -1ms (- 1.30%) 60ms 63ms
Req 4 - navto 204ms (± 0.88%) 204ms (± 0.48%) +0ms (+ 0.15%) 202ms 206ms
Req 5 - completionInfo count 3,206 (± 0.00%) 3,206 (± 0.00%) 0 ( 0.00%) 3,206 3,206
Req 5 - completionInfo 258ms (± 0.60%) 259ms (± 1.01%) +1ms (+ 0.27%) 255ms 268ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,455ms (± 0.57%) 1,450ms (± 0.31%) -5ms (- 0.35%) 1,439ms 1,459ms
Req 2 - geterr 3,550ms (± 0.91%) 3,533ms (± 0.44%) -17ms (- 0.48%) 3,495ms 3,565ms
Req 3 - references 233ms (± 0.49%) 232ms (± 0.55%) -1ms (- 0.39%) 229ms 236ms
Req 4 - navto 171ms (± 0.60%) 171ms (± 0.87%) +0ms (+ 0.23%) 168ms 174ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 59ms (± 6.06%) 56ms (± 4.58%) 🟩-3ms (- 5.41%) 54ms 66ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,524ms (± 0.44%) 1,531ms (± 0.86%) +7ms (+ 0.45%) 1,509ms 1,563ms
Req 2 - geterr 2,334ms (± 0.54%) 2,328ms (± 0.45%) -6ms (- 0.27%) 2,311ms 2,363ms
Req 3 - references 245ms (± 0.47%) 244ms (± 0.39%) -1ms (- 0.24%) 243ms 246ms
Req 4 - navto 181ms (± 0.45%) 181ms (± 0.62%) -0ms (- 0.06%) 178ms 184ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 55ms (± 1.35%) 55ms (± 1.10%) -1ms (- 1.45%) 54ms 56ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,149ms (± 0.64%) 2,147ms (± 0.49%) -2ms (- 0.11%) 2,125ms 2,173ms
Req 2 - geterr 767ms (± 0.47%) 775ms (± 0.57%) +8ms (+ 1.10%) 764ms 786ms
Req 3 - references 68ms (± 2.84%) 64ms (± 1.56%) 🟩-3ms (- 4.59%) 63ms 68ms
Req 4 - navto 228ms (± 0.87%) 228ms (± 0.70%) -0ms (- 0.09%) 225ms 232ms
Req 5 - completionInfo count 3,206 (± 0.00%) 3,206 (± 0.00%) 0 ( 0.00%) 3,206 3,206
Req 5 - completionInfo 273ms (± 1.53%) 276ms (± 0.91%) +4ms (+ 1.28%) 269ms 282ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-126-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51152 10
Baseline main 10

Developer Information:

Download Benchmark

@weswigham
Copy link
Member Author

Perf looks good (sometimes unreasonably so - looking at you TFS), so this looks like a pretty good approach to the problem.

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 12, 2022 •
edited
Loading

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at bcdac1a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 12, 2022 •
edited
Loading

Heya @weswigham, I've started to run the extended test suite on this PR at bcdac1a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 12, 2022 •
edited
Loading

Heya @weswigham, I've started to run the diff-based user code test suite on this PR at bcdac1a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@weswigham Here are the results of running the user test suite comparing main and refs/pull/51152/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/51152/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

3 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.json

src/tsconfig.tsec.json

@sandersn
Copy link
Member

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 27, 2022 •
edited
Loading

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at bcdac1a. You can monitor the build here.

@sandersn
Copy link
Member

Looks good; I started a DT run because something that increases the number of type identities sometimes fails there.

@weswigham
Copy link
Member Author

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 18, 2022 •
edited
Loading

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at ce91909. You can monitor the build here.

@weswigham weswigham merged commit a3092c7 into microsoft:main Nov 18, 2022
@nicolas377 nicolas377 mentioned this pull request Nov 22, 2022
Closed
@sandersn
Copy link
Member

Breaks 2 DT packages (lambda-tester, mparticle__web-sdk), in a way I can't understand yet. I'll open a bug.

@sandersn sandersn mentioned this pull request Nov 30, 2022
Closed
@jakebailey jakebailey mentioned this pull request Dec 6, 2022
Merged
@jakebailey jakebailey mentioned this pull request Jan 6, 2023
Merged
11 tasks
@SferaDev SferaDev mentioned this pull request Mar 25, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@sandersn sandersn sandersn approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@weswigham weswigham

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some types compile to a massive conditional type that causes performance issues
4 participants
@weswigham @typescript-bot @sandersn @andrewbranch