Remove unused declarations array in extractSymbol's TargetRange #51091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
We can't judge you for what we have done ourselves. You are fine. |
DanielRosenwasser
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting with making
Node.symbolan optional property while watching TV (please don't judge me for what I do in my free time); doing so only caught one meaningful bug:getRangeToExtractwas puttingundefinedinto an array that should have only containedSymbols.It turns out that this array is never actually read after it's built, hence why this never caused a crash. It's been this way since #17625, the PR that introduced this code.
(I checked the other properties, and they are all used.)