Skip to content

Remove configureLanguageServiceBuild, instrumenter #51048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

jakebailey
Copy link
Member

This is pulled out of my module branch for an early merge.

The "language service build" infrastructure was partially removed in #33684 and so doesn't work; remove the rest of it so I don't have to update it for modules.

The instrumenter is used to create new RWC tests by making an "instrumented" tsc executable that outputs IO information. Per internal discussion, we don't think we need this sort of thing anymore (we have the fuzzer/crawler/top100/etc), so remove it rather than try to make it work in the module-ified compiler.

ref: #49332

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 3, 2022
@jakebailey jakebailey merged commit 4953316 into microsoft:main Oct 4, 2022
@jakebailey jakebailey deleted the remove-build-stuff branch October 4, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants