Skip to content

Allow a union property of a private/protected member and an intersection property including that same member #50328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2022
Merged

Allow a union property of a private/protected member and an intersection property including that same member #50328

merged 1 commit into from
Sep 20, 2022

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Aug 17, 2022 •
edited
Loading

Fixes #49517

The issue and the fix are explained in the test comment. I’m only 50% sure this is correct.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 17, 2022
weswigham
weswigham approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks odd because there's already some other declaration logic below this during symbol creation, so we're kinda looking over the input list of declarations multiple times. Perf-wise, it's probably fine except in some edge cases where symbols have a ton of declarations, which is pretty rare. Might wanna run the perf suite just in case, anyway.

@andrewbranch
Copy link
Member Author

@typescript-bot perf test this
@typescript-bot user test this inline
@typescript-bot test top100
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at 7c904ee. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at 7c904ee. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the perf test suite on this PR at 7c904ee. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 13, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 7c904ee. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@andrewbranch Here are the results of running the user test suite comparing main and refs/pull/50328/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50328
Metric main 50328 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 363,328k (± 0.02%) 363,311k (± 0.01%) -17k (- 0.00%) 363,195k 363,413k
Parse Time 2.10s (± 0.71%) 2.10s (± 0.63%) -0.00s (- 0.14%) 2.06s 2.12s
Bind Time 0.79s (± 0.59%) 0.79s (± 0.75%) +0.00s (+ 0.51%) 0.78s 0.81s
Check Time 6.20s (± 0.37%) 6.20s (± 0.58%) +0.00s (+ 0.02%) 6.14s 6.28s
Emit Time 6.02s (± 0.52%) 6.01s (± 0.70%) -0.01s (- 0.15%) 5.89s 6.10s
Total Time 15.11s (± 0.27%) 15.11s (± 0.47%) -0.00s (- 0.01%) 14.87s 15.20s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,042k (± 0.30%) 206,207k (± 0.02%) +165k (+ 0.08%) 206,069k 206,330k
Parse Time 0.84s (± 0.62%) 0.84s (± 0.77%) -0.00s (- 0.36%) 0.82s 0.85s
Bind Time 0.47s (± 1.10%) 0.47s (± 0.85%) -0.00s (- 0.00%) 0.46s 0.48s
Check Time 8.54s (± 0.32%) 8.52s (± 0.54%) -0.02s (- 0.25%) 8.42s 8.60s
Emit Time 2.42s (± 0.79%) 2.42s (± 0.95%) -0.00s (- 0.08%) 2.38s 2.47s
Total Time 12.28s (± 0.24%) 12.25s (± 0.39%) -0.02s (- 0.17%) 12.13s 12.36s
Monaco - node (v10.16.3, x64)
Memory used 344,751k (± 0.01%) 344,802k (± 0.02%) +51k (+ 0.01%) 344,620k 344,944k
Parse Time 1.61s (± 0.58%) 1.62s (± 1.07%) +0.01s (+ 0.37%) 1.59s 1.66s
Bind Time 0.70s (± 0.83%) 0.70s (± 0.42%) +0.01s (+ 0.72%) 0.70s 0.71s
Check Time 6.22s (± 0.72%) 6.25s (± 0.51%) +0.03s (+ 0.48%) 6.16s 6.32s
Emit Time 3.20s (± 0.68%) 3.20s (± 0.74%) -0.00s (- 0.09%) 3.16s 3.25s
Total Time 11.73s (± 0.57%) 11.77s (± 0.54%) +0.04s (+ 0.36%) 11.61s 11.94s
TFS - node (v10.16.3, x64)
Memory used 305,994k (± 0.02%) 305,984k (± 0.03%) -10k (- 0.00%) 305,787k 306,162k
Parse Time 1.29s (± 0.81%) 1.30s (± 0.82%) +0.01s (+ 0.39%) 1.27s 1.31s
Bind Time 0.67s (± 0.71%) 0.67s (± 0.96%) -0.00s (- 0.15%) 0.66s 0.69s
Check Time 5.49s (± 0.57%) 5.53s (± 0.64%) +0.04s (+ 0.71%) 5.46s 5.64s
Emit Time 3.36s (± 1.12%) 3.40s (± 1.03%) +0.04s (+ 1.22%) 3.31s 3.47s
Total Time 10.81s (± 0.35%) 10.89s (± 0.34%) +0.08s (+ 0.78%) 10.81s 10.98s
material-ui - node (v10.16.3, x64)
Memory used 459,171k (± 0.01%) 459,226k (± 0.01%) +55k (+ 0.01%) 459,084k 459,328k
Parse Time 1.82s (± 0.95%) 1.84s (± 0.64%) +0.02s (+ 1.04%) 1.81s 1.86s
Bind Time 0.58s (± 1.56%) 0.58s (± 2.00%) -0.00s (- 0.69%) 0.56s 0.60s
Check Time 15.65s (± 0.41%) 15.81s (± 0.71%) +0.16s (+ 1.02%) 15.60s 16.11s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.05s (± 0.41%) 18.23s (± 0.65%) +0.17s (+ 0.96%) 18.01s 18.54s
xstate - node (v10.16.3, x64)
Memory used 584,141k (± 0.01%) 584,193k (± 0.02%) +52k (+ 0.01%) 584,028k 584,457k
Parse Time 2.62s (± 0.38%) 2.62s (± 0.26%) -0.00s (- 0.19%) 2.60s 2.63s
Bind Time 0.92s (± 0.56%) 0.92s (± 0.36%) -0.00s (- 0.11%) 0.91s 0.93s
Check Time 1.61s (± 0.55%) 1.62s (± 0.42%) +0.00s (+ 0.19%) 1.60s 1.63s
Emit Time 0.07s (± 4.13%) 0.07s (± 0.00%) -0.00s (- 2.78%) 0.07s 0.07s
Total Time 5.22s (± 0.25%) 5.22s (± 0.20%) -0.01s (- 0.13%) 5.19s 5.24s
Angular - node (v12.1.0, x64)
Memory used 340,829k (± 0.02%) 340,830k (± 0.02%) +1k (+ 0.00%) 340,685k 340,989k
Parse Time 2.07s (± 0.49%) 2.10s (± 0.55%) +0.02s (+ 1.06%) 2.06s 2.12s
Bind Time 0.77s (± 0.62%) 0.77s (± 0.44%) +0.01s (+ 0.78%) 0.77s 0.78s
Check Time 5.85s (± 0.47%) 5.83s (± 0.47%) -0.02s (- 0.27%) 5.77s 5.88s
Emit Time 6.19s (± 0.65%) 6.24s (± 0.65%) +0.05s (+ 0.73%) 6.15s 6.32s
Total Time 14.88s (± 0.46%) 14.94s (± 0.38%) +0.06s (+ 0.38%) 14.79s 15.06s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,830k (± 0.12%) 193,352k (± 0.44%) -478k (- 0.25%) 190,890k 194,195k
Parse Time 0.83s (± 0.48%) 0.83s (± 1.09%) +0.00s (+ 0.00%) 0.81s 0.85s
Bind Time 0.47s (± 1.60%) 0.47s (± 0.94%) -0.00s (- 0.63%) 0.46s 0.48s
Check Time 6.69s (± 0.75%) 6.72s (± 0.64%) +0.03s (+ 0.46%) 6.62s 6.82s
Emit Time 2.45s (± 2.13%) 2.43s (± 1.48%) -0.02s (- 0.74%) 2.36s 2.52s
Total Time 10.44s (± 0.92%) 10.45s (± 0.67%) +0.01s (+ 0.09%) 10.29s 10.63s
Monaco - node (v12.1.0, x64)
Memory used 327,671k (± 0.02%) 327,724k (± 0.02%) +54k (+ 0.02%) 327,534k 327,894k
Parse Time 1.59s (± 1.14%) 1.57s (± 0.57%) -0.02s (- 1.13%) 1.56s 1.60s
Bind Time 0.69s (± 0.49%) 0.70s (± 1.07%) +0.00s (+ 0.58%) 0.68s 0.71s
Check Time 5.82s (± 0.40%) 5.81s (± 0.47%) -0.01s (- 0.12%) 5.77s 5.88s
Emit Time 3.27s (± 1.40%) 3.25s (± 0.64%) -0.02s (- 0.46%) 3.20s 3.29s
Total Time 11.37s (± 0.68%) 11.34s (± 0.36%) -0.03s (- 0.28%) 11.27s 11.43s
TFS - node (v12.1.0, x64)
Memory used 290,438k (± 0.09%) 290,560k (± 0.07%) +121k (+ 0.04%) 289,763k 290,772k
Parse Time 1.29s (± 0.48%) 1.30s (± 0.83%) +0.01s (+ 0.78%) 1.28s 1.33s
Bind Time 0.67s (± 0.88%) 0.68s (± 0.66%) +0.00s (+ 0.59%) 0.67s 0.69s
Check Time 5.36s (± 0.36%) 5.40s (± 0.52%) +0.04s (+ 0.80%) 5.30s 5.44s
Emit Time 3.45s (± 0.89%) 3.46s (± 1.45%) +0.01s (+ 0.29%) 3.37s 3.56s
Total Time 10.77s (± 0.39%) 10.84s (± 0.67%) +0.06s (+ 0.60%) 10.63s 10.96s
material-ui - node (v12.1.0, x64)
Memory used 438,468k (± 0.01%) 438,447k (± 0.01%) -21k (- 0.00%) 438,336k 438,588k
Parse Time 1.83s (± 0.57%) 1.82s (± 0.58%) -0.01s (- 0.49%) 1.81s 1.85s
Bind Time 0.55s (± 0.73%) 0.55s (± 0.66%) +0.00s (+ 0.54%) 0.55s 0.56s
Check Time 12.79s (± 0.29%) 12.81s (± 0.69%) +0.02s (+ 0.13%) 12.64s 12.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.18s (± 0.22%) 15.19s (± 0.64%) +0.01s (+ 0.05%) 14.99s 15.35s
xstate - node (v12.1.0, x64)
Memory used 549,107k (± 0.01%) 549,300k (± 0.02%) +192k (+ 0.04%) 549,119k 549,538k
Parse Time 2.53s (± 0.50%) 2.54s (± 0.55%) +0.01s (+ 0.47%) 2.52s 2.59s
Bind Time 0.89s (± 0.54%) 0.90s (± 0.91%) +0.01s (+ 1.13%) 0.88s 0.91s
Check Time 1.48s (± 0.49%) 1.49s (± 0.68%) +0.01s (+ 0.54%) 1.47s 1.50s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 4.97s (± 0.28%) 5.00s (± 0.38%) +0.02s (+ 0.48%) 4.95s 5.03s
Angular - node (v14.15.1, x64)
Memory used 338,916k (± 0.01%) 338,941k (± 0.01%) +25k (+ 0.01%) 338,879k 338,993k
Parse Time 2.06s (± 0.56%) 2.07s (± 0.86%) +0.00s (+ 0.19%) 2.04s 2.12s
Bind Time 0.80s (± 0.84%) 0.80s (± 1.25%) +0.00s (+ 0.38%) 0.78s 0.83s
Check Time 5.86s (± 0.51%) 5.87s (± 0.40%) +0.01s (+ 0.17%) 5.81s 5.92s
Emit Time 6.21s (± 0.71%) 6.21s (± 0.59%) +0.00s (+ 0.08%) 6.14s 6.32s
Total Time 14.93s (± 0.35%) 14.95s (± 0.42%) +0.02s (+ 0.15%) 14.81s 15.06s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,286k (± 0.91%) 190,725k (± 0.68%) -562k (- 0.29%) 190,108k 195,953k
Parse Time 0.85s (± 1.13%) 0.86s (± 0.72%) +0.01s (+ 0.94%) 0.84s 0.87s
Bind Time 0.48s (± 0.77%) 0.50s (± 2.01%) +0.01s (+ 2.47%) 0.48s 0.53s
Check Time 6.73s (± 0.29%) 6.76s (± 0.49%) +0.02s (+ 0.37%) 6.71s 6.83s
Emit Time 2.38s (± 0.86%) 2.38s (± 0.99%) +0.00s (+ 0.04%) 2.34s 2.42s
Total Time 10.45s (± 0.28%) 10.49s (± 0.33%) +0.05s (+ 0.45%) 10.42s 10.56s
Monaco - node (v14.15.1, x64)
Memory used 326,581k (± 0.01%) 326,586k (± 0.01%) +6k (+ 0.00%) 326,553k 326,636k
Parse Time 1.59s (± 1.10%) 1.58s (± 0.72%) -0.01s (- 0.38%) 1.56s 1.61s
Bind Time 0.72s (± 0.55%) 0.73s (± 0.50%) +0.01s (+ 0.69%) 0.72s 0.73s
Check Time 5.70s (± 0.41%) 5.72s (± 0.21%) +0.03s (+ 0.44%) 5.70s 5.75s
Emit Time 3.31s (± 0.61%) 3.33s (± 0.59%) +0.02s (+ 0.54%) 3.29s 3.38s
Total Time 11.32s (± 0.28%) 11.37s (± 0.21%) +0.04s (+ 0.36%) 11.33s 11.44s
TFS - node (v14.15.1, x64)
Memory used 289,693k (± 0.00%) 289,684k (± 0.01%) -9k (- 0.00%) 289,632k 289,746k
Parse Time 1.30s (± 0.46%) 1.30s (± 0.43%) -0.00s (- 0.15%) 1.29s 1.31s
Bind Time 0.79s (± 0.51%) 0.79s (± 1.33%) -0.00s (- 0.13%) 0.75s 0.80s
Check Time 5.37s (± 0.49%) 5.34s (± 0.40%) -0.02s (- 0.45%) 5.30s 5.39s
Emit Time 3.54s (± 0.43%) 3.55s (± 0.59%) +0.01s (+ 0.28%) 3.52s 3.60s
Total Time 11.00s (± 0.32%) 10.98s (± 0.26%) -0.02s (- 0.15%) 10.93s 11.03s
material-ui - node (v14.15.1, x64)
Memory used 436,528k (± 0.06%) 436,655k (± 0.01%) +126k (+ 0.03%) 436,612k 436,736k
Parse Time 1.87s (± 0.56%) 1.88s (± 0.51%) +0.01s (+ 0.37%) 1.86s 1.90s
Bind Time 0.58s (± 1.28%) 0.58s (± 0.99%) 0.00s ( 0.00%) 0.57s 0.59s
Check Time 12.89s (± 0.62%) 12.95s (± 0.85%) +0.06s (+ 0.45%) 12.70s 13.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.34s (± 0.54%) 15.41s (± 0.75%) +0.07s (+ 0.45%) 15.13s 15.60s
xstate - node (v14.15.1, x64)
Memory used 546,991k (± 0.00%) 547,101k (± 0.00%) +111k (+ 0.02%) 547,070k 547,146k
Parse Time 2.61s (± 0.59%) 2.61s (± 0.34%) 0.00s ( 0.00%) 2.59s 2.64s
Bind Time 0.97s (± 0.82%) 0.99s (± 1.13%) +0.02s (+ 1.95%) 0.97s 1.02s
Check Time 1.52s (± 0.63%) 1.53s (± 0.57%) +0.00s (+ 0.20%) 1.51s 1.54s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.18s (± 0.36%) 5.21s (± 0.26%) +0.03s (+ 0.62%) 5.19s 5.25s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50328 10
Baseline main 10

TSServer

Comparison Report - main..50328
Metric main 50328 Delta Best Worst
Compiler-UnionsTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,405ms (± 0.39%) 1,412ms (± 0.44%) +7ms (+ 0.46%) 1,396ms 1,424ms
Req 2 - geterr 4,105ms (± 0.81%) 4,126ms (± 0.86%) +22ms (+ 0.52%) 4,046ms 4,213ms
Req 3 - references 228ms (± 0.86%) 230ms (± 0.63%) +2ms (+ 0.96%) 227ms 234ms
Req 4 - navto 173ms (± 1.15%) 174ms (± 0.87%) +1ms (+ 0.58%) 169ms 177ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 96ms (± 3.08%) 96ms (± 3.52%) +1ms (+ 0.63%) 89ms 104ms
CompilerTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,496ms (± 0.58%) 1,506ms (± 0.70%) +11ms (+ 0.72%) 1,482ms 1,529ms
Req 2 - geterr 2,254ms (± 0.41%) 2,264ms (± 0.41%) +10ms (+ 0.46%) 2,245ms 2,289ms
Req 3 - references 244ms (± 0.79%) 246ms (± 0.94%) +1ms (+ 0.57%) 243ms 252ms
Req 4 - navto 185ms (± 0.97%) 186ms (± 0.60%) +1ms (+ 0.54%) 184ms 188ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 62ms (± 1.08%) 63ms (± 2.77%) +1ms (+ 1.30%) 60ms 69ms
xstateTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 2,089ms (± 0.28%) 2,098ms (± 0.35%) +9ms (+ 0.41%) 2,079ms 2,117ms
Req 2 - geterr 794ms (± 0.82%) 798ms (± 0.59%) +4ms (+ 0.47%) 790ms 810ms
Req 3 - references 99ms (± 1.85%) 98ms (± 1.84%) -1ms (- 0.61%) 94ms 102ms
Req 4 - navto 232ms (± 1.19%) 232ms (± 0.89%) +0ms (+ 0.09%) 228ms 236ms
Req 5 - completionInfo count 3,301 (± 0.00%) 3,301 (± 0.00%) 0 ( 0.00%) 3,301 3,301
Req 5 - completionInfo 280ms (± 1.43%) 281ms (± 1.25%) +1ms (+ 0.29%) 272ms 287ms
Compiler-UnionsTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,405ms (± 0.81%) 1,412ms (± 0.69%) +7ms (+ 0.51%) 1,398ms 1,441ms
Req 2 - geterr 3,392ms (± 0.69%) 3,373ms (± 0.79%) -19ms (- 0.56%) 3,322ms 3,447ms
Req 3 - references 220ms (± 0.70%) 220ms (± 0.58%) +1ms (+ 0.23%) 218ms 224ms
Req 4 - navto 159ms (± 1.09%) 160ms (± 0.88%) +1ms (+ 0.38%) 156ms 162ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 59ms (± 3.07%) 61ms (± 5.42%) +2ms (+ 2.69%) 54ms 66ms
CompilerTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,495ms (± 0.62%) 1,499ms (± 0.66%) +4ms (+ 0.28%) 1,478ms 1,523ms
Req 2 - geterr 2,163ms (± 0.46%) 2,167ms (± 0.47%) +4ms (+ 0.20%) 2,142ms 2,190ms
Req 3 - references 235ms (± 0.43%) 234ms (± 0.76%) -1ms (- 0.34%) 229ms 238ms
Req 4 - navto 169ms (± 1.08%) 171ms (± 0.76%) +2ms (+ 1.13%) 168ms 174ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 60ms (± 2.91%) 63ms (± 3.01%) +3ms (+ 5.21%) 59ms 67ms
xstateTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 2,038ms (± 0.64%) 2,054ms (± 0.50%) +16ms (+ 0.78%) 2,034ms 2,075ms
Req 2 - geterr 747ms (± 0.73%) 751ms (± 0.86%) +4ms (+ 0.50%) 742ms 771ms
Req 3 - references 67ms (± 1.12%) 67ms (± 1.40%) -0ms (- 0.15%) 65ms 69ms
Req 4 - navto 222ms (± 1.48%) 225ms (± 1.07%) +3ms (+ 1.12%) 218ms 229ms
Req 5 - completionInfo count 3,301 (± 0.00%) 3,301 (± 0.00%) 0 ( 0.00%) 3,301 3,301
Req 5 - completionInfo 276ms (± 1.18%) 274ms (± 0.98%) -2ms (- 0.69%) 265ms 278ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,446ms (± 0.38%) 1,445ms (± 0.63%) -1ms (- 0.06%) 1,425ms 1,464ms
Req 2 - geterr 3,514ms (± 0.89%) 3,498ms (± 0.48%) -16ms (- 0.46%) 3,469ms 3,532ms
Req 3 - references 230ms (± 0.51%) 231ms (± 0.43%) +1ms (+ 0.39%) 229ms 233ms
Req 4 - navto 169ms (± 0.68%) 171ms (± 0.76%) +2ms (+ 0.95%) 169ms 175ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 57ms (± 6.11%) 56ms (± 1.00%) -1ms (- 2.45%) 55ms 57ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,516ms (± 0.63%) 1,526ms (± 0.48%) +10ms (+ 0.63%) 1,507ms 1,540ms
Req 2 - geterr 2,298ms (± 0.49%) 2,310ms (± 0.51%) +12ms (+ 0.50%) 2,287ms 2,339ms
Req 3 - references 242ms (± 0.59%) 242ms (± 0.89%) +0ms (+ 0.08%) 237ms 247ms
Req 4 - navto 178ms (± 0.50%) 178ms (± 0.78%) +0ms (+ 0.11%) 174ms 180ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 55ms (± 0.90%) 56ms (± 0.67%) +1ms (+ 1.65%) 55ms 56ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,139ms (± 0.56%) 2,151ms (± 0.57%) +12ms (+ 0.56%) 2,133ms 2,187ms
Req 2 - geterr 766ms (± 0.40%) 771ms (± 0.60%) +6ms (+ 0.74%) 762ms 780ms
Req 3 - references 68ms (± 1.73%) 67ms (± 1.36%) -1ms (- 1.47%) 64ms 68ms
Req 4 - navto 227ms (± 0.73%) 230ms (± 1.62%) +3ms (+ 1.28%) 223ms 242ms
Req 5 - completionInfo count 3,301 (± 0.00%) 3,301 (± 0.00%) 0 ( 0.00%) 3,301 3,301
Req 5 - completionInfo 277ms (± 0.68%) 277ms (± 0.79%) +1ms (+ 0.29%) 273ms 281ms
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v10.16.3, x64)
  • Compiler-UnionsTSServer - node (v12.1.0, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v10.16.3, x64)
  • CompilerTSServer - node (v12.1.0, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50328 10
Baseline main 10

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@andrewbranch Here are the results of running the top-repos suite comparing main and refs/pull/50328/merge:

Everything looks good!

@andrewbranch andrewbranch merged commit 168186f into microsoft:main Sep 20, 2022
@andrewbranch andrewbranch deleted the bug/49517 branch September 20, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@andrewbranch andrewbranch

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protected field with same name in two classes messing up type constraint when narrowing array.
3 participants
@andrewbranch @typescript-bot @weswigham