Fix type parameter comparability to consistently allow comparisons on unconstrained type parameters #48861
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| tests/cases/compiler/genericWithNoConstraintComparableWithCurlyCurly.ts(23,5): error TS2352: Conversion of type '{}' to type 'T' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first. | ||
| 'T' could be instantiated with an arbitrary type which could be unrelated to '{}'. | ||
|
|
||
|
|
||
| ==== tests/cases/compiler/genericWithNoConstraintComparableWithCurlyCurly.ts (1 errors) ==== | ||
| function foo<T>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function bar<T extends unknown>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function baz<T extends {}>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function bat<T extends object>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function no<T extends null | undefined>() { | ||
| let x = {}; | ||
| x as T; // should error | ||
| ~~~~~~ | ||
| !!! error TS2352: Conversion of type '{}' to type 'T' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first. | ||
| !!! error TS2352: 'T' could be instantiated with an arbitrary type which could be unrelated to '{}'. | ||
| } | ||
|
|
||
| function yes<T extends object | null | undefined>() { | ||
| let x = {}; | ||
| x as T; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| //// [genericWithNoConstraintComparableWithCurlyCurly.ts] | ||
| function foo<T>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function bar<T extends unknown>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function baz<T extends {}>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function bat<T extends object>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function no<T extends null | undefined>() { | ||
| let x = {}; | ||
| x as T; // should error | ||
| } | ||
|
|
||
| function yes<T extends object | null | undefined>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| //// [genericWithNoConstraintComparableWithCurlyCurly.js] | ||
| "use strict"; | ||
| function foo() { | ||
| var x = {}; | ||
| x; | ||
| } | ||
| function bar() { | ||
| var x = {}; | ||
| x; | ||
| } | ||
| function baz() { | ||
| var x = {}; | ||
| x; | ||
| } | ||
| function bat() { | ||
| var x = {}; | ||
| x; | ||
| } | ||
| function no() { | ||
| var x = {}; | ||
| x; // should error | ||
| } | ||
| function yes() { | ||
| var x = {}; | ||
| x; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| === tests/cases/compiler/genericWithNoConstraintComparableWithCurlyCurly.ts === | ||
| function foo<T>() { | ||
| >foo : Symbol(foo, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 0, 0)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 0, 13)) | ||
|
|
||
| let x = {}; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 1, 7)) | ||
|
|
||
| x as T; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 1, 7)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 0, 13)) | ||
| } | ||
|
|
||
| function bar<T extends unknown>() { | ||
| >bar : Symbol(bar, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 3, 1)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 5, 13)) | ||
|
|
||
| let x = {}; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 6, 7)) | ||
|
|
||
| x as T; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 6, 7)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 5, 13)) | ||
| } | ||
|
|
||
| function baz<T extends {}>() { | ||
| >baz : Symbol(baz, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 8, 1)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 10, 13)) | ||
|
|
||
| let x = {}; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 11, 7)) | ||
|
|
||
| x as T; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 11, 7)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 10, 13)) | ||
| } | ||
|
|
||
| function bat<T extends object>() { | ||
| >bat : Symbol(bat, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 13, 1)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 15, 13)) | ||
|
|
||
| let x = {}; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 16, 7)) | ||
|
|
||
| x as T; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 16, 7)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 15, 13)) | ||
| } | ||
|
|
||
| function no<T extends null | undefined>() { | ||
| >no : Symbol(no, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 18, 1)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 20, 12)) | ||
|
|
||
| let x = {}; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 21, 7)) | ||
|
|
||
| x as T; // should error | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 21, 7)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 20, 12)) | ||
| } | ||
|
|
||
| function yes<T extends object | null | undefined>() { | ||
| >yes : Symbol(yes, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 23, 1)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 25, 13)) | ||
|
|
||
| let x = {}; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 26, 7)) | ||
|
|
||
| x as T; | ||
| >x : Symbol(x, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 26, 7)) | ||
| >T : Symbol(T, Decl(genericWithNoConstraintComparableWithCurlyCurly.ts, 25, 13)) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| === tests/cases/compiler/genericWithNoConstraintComparableWithCurlyCurly.ts === | ||
| function foo<T>() { | ||
| >foo : <T>() => void | ||
|
|
||
| let x = {}; | ||
| >x : {} | ||
| >{} : {} | ||
|
|
||
| x as T; | ||
| >x as T : T | ||
| >x : {} | ||
| } | ||
|
|
||
| function bar<T extends unknown>() { | ||
| >bar : <T extends unknown>() => void | ||
|
|
||
| let x = {}; | ||
| >x : {} | ||
| >{} : {} | ||
|
|
||
| x as T; | ||
| >x as T : T | ||
| >x : {} | ||
| } | ||
|
|
||
| function baz<T extends {}>() { | ||
| >baz : <T extends {}>() => void | ||
|
|
||
| let x = {}; | ||
| >x : {} | ||
| >{} : {} | ||
|
|
||
| x as T; | ||
| >x as T : T | ||
| >x : {} | ||
| } | ||
|
|
||
| function bat<T extends object>() { | ||
| >bat : <T extends object>() => void | ||
|
|
||
| let x = {}; | ||
| >x : {} | ||
| >{} : {} | ||
|
|
||
| x as T; | ||
| >x as T : T | ||
| >x : {} | ||
| } | ||
|
|
||
| function no<T extends null | undefined>() { | ||
| >no : <T extends null | undefined>() => void | ||
| >null : null | ||
|
|
||
| let x = {}; | ||
| >x : {} | ||
| >{} : {} | ||
|
|
||
| x as T; // should error | ||
| >x as T : T | ||
| >x : {} | ||
| } | ||
|
|
||
| function yes<T extends object | null | undefined>() { | ||
| >yes : <T extends object | null | undefined>() => void | ||
| >null : null | ||
|
|
||
| let x = {}; | ||
| >x : {} | ||
| >{} : {} | ||
|
|
||
| x as T; | ||
| >x as T : T | ||
| >x : {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // @strict: true | ||
| function foo<T>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function bar<T extends unknown>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function baz<T extends {}>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function bat<T extends object>() { | ||
| let x = {}; | ||
| x as T; | ||
| } | ||
|
|
||
| function no<T extends null | undefined>() { | ||
| let x = {}; | ||
| x as T; // should error | ||
| } | ||
|
|
||
| function yes<T extends object | null | undefined>() { | ||
| let x = {}; | ||
| x as T; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.