Emit class fields as-is with target: es2022
#47018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Merged
sandersn
approved these changes
Dec 16, 2021
|
It seems this PR breaks the build. Not sure, maybe need to update the baseline. |
|
Yep, it's because of the other recent PR that de-dupes private field errors. I'll update the baselines and send a PR. |
|
@sandersn I can make PR, with updated baselines. |
|
Don't worry, I've got it. |
|
Oke, thanks. |
sandersn
added a commit
that referenced
this pull request
Dec 17, 2021
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Emit class fields as-is with `target: es2022` Closes microsoft#47017 * wave 2
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
Conflict between microsoft#47018 and microsoft#46824, both of which changed the behaviour of private fields.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47017