Skip to content

🤖 Pick PR #46599 (Improve recursion depth checks) into release-4.5 #46974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

🤖 Pick PR #46599 (Improve recursion depth checks) into release-4.5 #46974

merged 1 commit into from
Dec 7, 2021

Conversation

@typescript-bot
Copy link
Collaborator

This cherry-pick was triggered by a request on #46599
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @DanielRosenwasser

@typescript-bot typescript-bot mentioned this pull request Dec 1, 2021
Merged
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 1, 2021
@ahejlsberg @andrewbranch
Cherry-pick PR microsoft#46599 into release-4.5
156d219 
Component commits:
ddc106b Decrease recursion depth limit to 3 + smarter check for recursion

86185ad Accept new baselines

52e10d3 Always set last type id

5f37d89 Keep indexed access recursion depth check

9df07a8 Less expensive and corrected check for broadest equivalent keys
@andrewbranch andrewbranch force-pushed the pick/46599/release-4.5 branch from f26e0d1 to 156d219 Compare December 3, 2021 23:20
@DanielRosenwasser DanielRosenwasser merged commit ae44862 into microsoft:release-4.5 Dec 7, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 1, 2022
Closed
@andrewbranch andrewbranch mentioned this pull request Sep 12, 2022
Closed
@martinwepner martinwepner mentioned this pull request Feb 22, 2023
Open
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@DanielRosenwasser DanielRosenwasser

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@typescript-bot @DanielRosenwasser @ahejlsberg