Skip to content

Fix parsing of parenthesized functions in conditional expressions #46960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

jakebailey
Copy link
Member

Fixes #46933

When we speculatively parse after ?, function() {} may be within parens and appear as a parenthesized JSDoc function type.

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Nov 30, 2021
@RyanCavanaugh
Copy link
Member

Ryan on Jake's first day: Don't merge anything with red CI, of course
Ryan on Jake's second day: You should merge despite this red CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createSourceFile build wrong AST in some cases.
3 participants