Skip to content

Fix verify.baselineCompletions used in fourslash tests #45615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix verify.baselineCompletions used in fourslash tests #45615

merged 1 commit into from
Aug 30, 2021

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Aug 28, 2021

Related #43709

I found while working on #43710 that the verify.baselineCompletions used in the fourslash tests were not working properly. This pull request is to fix it.

#43710 (comment)

@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 28, 2021
@petamoriken
Copy link
Contributor Author

@sandersn Please review this code.

@DanielRosenwasser DanielRosenwasser merged commit 9d81536 into microsoft:main Aug 30, 2021
@DanielRosenwasser
Copy link
Member

Thanks!

@petamoriken petamoriken deleted the fix/fourslash-baseline-completions branch August 30, 2021 07:49
BobobUnicorn pushed a commit to BobobUnicorn/TypeScript that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants