Skip to content

Expose text property of SourceFileLike for some Public APIs #44599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

cubenoy22
Copy link
Contributor

@cubenoy22 cubenoy22 commented Jun 15, 2021

Fixes #44250

This change makes two APIs available like this: Playground

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 15, 2021
@ghost
Copy link

ghost commented Jun 15, 2021

CLA assistant check
All CLA requirements met.

@cubenoy22 cubenoy22 force-pushed the expose-sourcefilelike-member branch from d072813 to cae9265 Compare June 15, 2021 16:13
@sandersn sandersn requested review from sandersn and orta July 2, 2021 00:08
@sandersn sandersn assigned sandersn and orta and unassigned sandersn Jul 2, 2021
@sandersn
Copy link
Member

sandersn commented Jul 2, 2021

I still don't think I understand the original request, so that's my first task here.

@sandersn sandersn removed the request for review from orta February 25, 2022 02:02
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #44250. If you can get it accepted, this PR will have a better chance of being reviewed.

@sandersn sandersn assigned sandersn and unassigned orta Feb 25, 2022
@sandersn sandersn requested a review from gabritto February 25, 2022 02:04
@sandersn sandersn merged commit 0043abe into microsoft:main Feb 25, 2022
@cubenoy22 cubenoy22 deleted the expose-sourcefilelike-member branch February 26, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make incomplete scanner APIs internal
4 participants