Pass throwIfNoEntry to fs.statSync #41604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found. See nodejs/node#33716
typescript-bot
added
Author: Team
For Uncommitted Bug
DanielRosenwasser
approved these changes
Nov 23, 2020
sheetalkamat
approved these changes
Nov 23, 2020
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 14, 2021
Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found. See nodejs/node#33716
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 14, 2021
Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found. See nodejs/node#33716
DanielRosenwasser
pushed a commit
that referenced
this pull request
Jun 14, 2021
Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found. See nodejs/node#33716
This was referenced Jun 14, 2021
DanielRosenwasser
added a commit
that referenced
this pull request
Jun 15, 2021
Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found. See nodejs/node#33716 Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
DanielRosenwasser
added a commit
that referenced
this pull request
Jun 15, 2021
Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found. See nodejs/node#33716 Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
DanielRosenwasser
added a commit
that referenced
this pull request
Jun 15, 2021
Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found. See nodejs/node#33716 Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future versions of node will be able to return undefined, rather than allocating and throwing an exception, when a file is not found.
See nodejs/node#33716