Skip to content

fix(39676): Default code action for unused function parameter (6133) in non-final position should not delete #40299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2020
Merged

fix(39676): Default code action for unused function parameter (6133) in non-final position should not delete #40299

merged 1 commit into from
Sep 9, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #39676

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 28, 2020
sandersn
sandersn requested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the bug it looks like the codefix should only ever apply to non-final parameters. Are there cases where non-final parameters are correctly deleted today?

@sandersn sandersn merged commit 4584d6d into microsoft:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default code action for unused function parameter (6133) in non-final position should not delete
3 participants
@a-tarasyuk @sandersn @typescript-bot