fix(26141): String type autocomplete doesn't work with paren #39697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-tarasyuk
force-pushed
the
bug/26141
branch
from
8418c9a to
0717061
Compare
a-tarasyuk
force-pushed
the
bug/26141
branch
2 times, most recently
from
2cc8a06 to
703f3be
Compare
sandersn
requested changes
Sep 3, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Would it work to use skipParentheses instead of recursion?
Also I don't understand why ImportType and UnionType need to return undefined for non-string-literals.
a-tarasyuk
force-pushed
the
bug/26141
branch
from
703f3be to
8f54ed7
Compare
sandersn
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26141