Skip to content

Do not resolve require calls in typescript files even if it contains dynamic import #39617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2020
Merged

Do not resolve require calls in typescript files even if it contains dynamic import #39617

merged 2 commits into from
Jul 15, 2020

Conversation

@sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Jul 15, 2020

Fixes #38611

@sheetalkamat sheetalkamat merged commit 37e6e27 into master Jul 15, 2020
@sheetalkamat sheetalkamat deleted the requireInTs branch July 15, 2020 21:32
@DanielRosenwasser DanielRosenwasser mentioned this pull request Jul 17, 2020
Merged
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham weswigham weswigham approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@sheetalkamat sheetalkamat

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tsc complains require() file path outside of rootDir only when await import() is used

4 participants

@sheetalkamat @weswigham @typescript-bot