Skip to content

Don’t give all instantiated signatures in JS strict arity #39606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

Don’t give all instantiated signatures in JS strict arity #39606

merged 1 commit into from
Jul 15, 2020

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Jul 14, 2020

Fixes #39261

@andrewbranch andrewbranch requested a review from weswigham July 14, 2020 23:51
weswigham
weswigham approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@andrewbranch andrewbranch merged commit dd2fc86 into microsoft:master Jul 15, 2020
@andrewbranch andrewbranch deleted the bug/39261 branch July 15, 2020 01:56
@sandersn sandersn mentioned this pull request Jul 31, 2020
Merged
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@andrewbranch andrewbranch

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ts-check error ts(2554) after upgrading to 1.46.1 when calling class member function with optionals

3 participants

@andrewbranch @weswigham @typescript-bot