Skip to content

fix(39373): const {} = require import causes Debug Failure #39567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/compiler/diagnosticMessages.json
Original file line number Diff line number Diff line change
Expand Up @@ -3041,6 +3041,10 @@
"category": "Error",
"code": 4020
},
"'extends' clause of exported class has or is using private name '{0}'.": {
"category": "Error",
"code": 4021
},
"'extends' clause of exported interface '{0}' has or is using private name '{1}'.": {
"category": "Error",
"code": 4022
Expand Down
5 changes: 3 additions & 2 deletions src/compiler/transformers/declarations/diagnostics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,12 @@ namespace ts {
function getHeritageClauseVisibilityError(): SymbolAccessibilityDiagnostic {
let diagnosticMessage: DiagnosticMessage;
// Heritage clause is written by user so it can always be named
if (node.parent.parent.kind === SyntaxKind.ClassDeclaration) {
if (isClassDeclaration(node.parent.parent)) {
// Class or Interface implemented/extended is inaccessible
diagnosticMessage = isHeritageClause(node.parent) && node.parent.token === SyntaxKind.ImplementsKeyword ?
Diagnostics.Implements_clause_of_exported_class_0_has_or_is_using_private_name_1 :
Diagnostics.extends_clause_of_exported_class_0_has_or_is_using_private_name_1;
node.parent.parent.name ? Diagnostics.extends_clause_of_exported_class_0_has_or_is_using_private_name_1 :
Diagnostics.extends_clause_of_exported_class_has_or_is_using_private_name_0;
}
else {
// interface is inaccessible
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/b.ts(2,30): error TS4021: 'extends' clause of exported class has or is using private name 'Foo'.


==== /b.ts (1 errors) ====
const { Foo } = require("./a");
export default class extends Foo {}
~~~
!!! error TS4021: 'extends' clause of exported class has or is using private name 'Foo'.

==== /node_modules/@types/node/index.d.ts (0 errors) ====
declare const require: any;

==== /a.ts (0 errors) ====
export class Foo {}

38 changes: 38 additions & 0 deletions tests/baselines/reference/declarationEmitExpressionInExtends6.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
//// [tests/cases/compiler/declarationEmitExpressionInExtends6.ts] ////

//// [index.d.ts]
declare const require: any;

//// [a.ts]
export class Foo {}

//// [b.ts]
const { Foo } = require("./a");
export default class extends Foo {}


//// [b.js]
"use strict";
var __extends = (this && this.__extends) || (function () {
var extendStatics = function (d, b) {
extendStatics = Object.setPrototypeOf ||
({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) ||
function (d, b) { for (var p in b) if (Object.prototype.hasOwnProperty.call(b, p)) d[p] = b[p]; };
return extendStatics(d, b);
};
return function (d, b) {
extendStatics(d, b);
function __() { this.constructor = d; }
d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
})();
exports.__esModule = true;
var Foo = require("./a").Foo;
var default_1 = /** @class */ (function (_super) {
__extends(default_1, _super);
function default_1() {
return _super !== null && _super.apply(this, arguments) || this;
}
return default_1;
}(Foo));
exports["default"] = default_1;
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
=== /b.ts ===
const { Foo } = require("./a");
>Foo : Symbol(Foo, Decl(b.ts, 0, 7))
>require : Symbol(require, Decl(index.d.ts, 0, 13))

export default class extends Foo {}
>Foo : Symbol(Foo, Decl(b.ts, 0, 7))

=== /node_modules/@types/node/index.d.ts ===
declare const require: any;
>require : Symbol(require, Decl(index.d.ts, 0, 13))

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
=== /b.ts ===
const { Foo } = require("./a");
>Foo : any
>require("./a") : any
>require : any
>"./a" : "./a"

export default class extends Foo {}
>Foo : any

=== /node_modules/@types/node/index.d.ts ===
declare const require: any;
>require : any

14 changes: 14 additions & 0 deletions tests/cases/compiler/declarationEmitExpressionInExtends6.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// @module: commonjs
// @declaration: true
// @types: node
// @currentDirectory: /

// @Filename: /node_modules/@types/node/index.d.ts
declare const require: any;

// @Filename: /a.ts
export class Foo {}

// @Filename: /b.ts
const { Foo } = require("./a");
export default class extends Foo {}