-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Remove extraneous string escape from convert to template string refactor #37743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny style comment
@orta, playwright failed to install all of a sudden on node 8 both in Actions and in Pipelines. Have you seen this before? 🤔 |
No, this sounds like the first time it's failed full stop |
Because the dep isn't locked, it looks like it needs bumping to node 10 |
I can't tell if this is supposed to have landed in production yet. I'm running VSCode 1.49.0, which I think is TS 4.0 under the hood. Should I expect the behavior I'm seeing to include this PR? I came here because I just converted The missing character I pasted in there looks like an empty square in the GH Markdown editor but a question-mark inside a black diamond in the preview. I copied the character, then pasted into the Chrome dev tools console as Obviously, in my case I actually meant to write I guess what I'm asking is, should I open a new issue? |
@thw0rted yes, if you could open a new issue, that would be great. Thank you! |
Fixes #37330
String literal
text
should be transferred to template head/tailtext
without modification—it gets escaped in the printer.