Skip to content

use const instead of let for new class iife assignments #36907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/transformers/ts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ namespace ts {
/*type*/ undefined,
iife
)
], languageVersion > ScriptTarget.ES5 ? NodeFlags.Let : undefined)
], languageVersion > ScriptTarget.ES5 ? NodeFlags.Const : undefined)
);

setOriginalNode(varStatement, node);
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/awaitAndYieldInProperty.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async function* test(x: Promise<string>) {
//// [awaitAndYieldInProperty.js]
async function* test(x) {
var _a, _b, _c, _d, _e;
let C = /** @class */ (() => {
const C = /** @class */ (() => {
var _e, _f, _g, _h;
class C {
constructor() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class C3 {
}

//// [classDeclarationCheckUsedBeforeDefinitionInItself.js]
let C3 = /** @class */ (() => {
const C3 = /** @class */ (() => {
class C3 {
}
C3.intance = new C3(); // ok
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/computedPropertyNames12_ES6.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class C {
var s;
var n;
var a;
let C = /** @class */ (() => {
const C = /** @class */ (() => {
var _a, _b, _c;
class C {
constructor() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class C {
}

//// [computedPropertyNamesWithStaticProperty.js]
let C = /** @class */ (() => {
const C = /** @class */ (() => {
class C {
get [C.staticProp]() {
return "hello";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
Object.defineProperty(exports, "__esModule", { value: true });
let Testing123 = /** @class */ (() => {
const Testing123 = /** @class */ (() => {
var Testing123_1;
let Testing123 = Testing123_1 = class Testing123 {
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
Object.defineProperty(exports, "__esModule", { value: true });
let Testing123 = /** @class */ (() => {
const Testing123 = /** @class */ (() => {
var Testing123_1;
let Testing123 = Testing123_1 = class Testing123 {
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
function decorate(target) { }
let Decorated = /** @class */ (() => {
const Decorated = /** @class */ (() => {
let Decorated = class Decorated {
};
Decorated = __decorate([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ define(["require", "exports"], function (require, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var decorator;
let Foo = /** @class */ (() => {
const Foo = /** @class */ (() => {
let Foo = class Foo {
};
Foo = __decorate([
Expand All @@ -45,7 +45,7 @@ define(["require", "exports"], function (require, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var decorator;
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
let default_1 = class {
};
default_1 = __decorate([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
};
Object.defineProperty(exports, "__esModule", { value: true });
var decorator;
let Foo = /** @class */ (() => {
const Foo = /** @class */ (() => {
let Foo = class Foo {
};
Foo = __decorate([
Expand All @@ -42,7 +42,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
};
Object.defineProperty(exports, "__esModule", { value: true });
var decorator;
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
let default_1 = class {
};
default_1 = __decorate([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var decorator;
let Foo = /** @class */ (() => {
const Foo = /** @class */ (() => {
let Foo = class Foo {
};
Foo = __decorate([
Expand Down Expand Up @@ -61,7 +61,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
var decorator;
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
let default_1 = class {
};
default_1 = __decorate([
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorMetadataPromise.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
step((generator = generator.apply(thisArg, _arguments || [])).next());
});
};
let A = /** @class */ (() => {
const A = /** @class */ (() => {
class A {
foo() {
return __awaiter(this, void 0, void 0, function* () { });
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass1.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
let C = class C {
};
C = __decorate([
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass2.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
let C = class C {
};
C = __decorate([
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass3.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
let C = class C {
};
C = __decorate([
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass4.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
let default_1 = class {
};
default_1 = __decorate([
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass5.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
var C_1;
let C = C_1 = class C {
static x() { return C_1.y; }
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass6.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
var C_1;
let C = C_1 = class C {
static x() { return C_1.y; }
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass7.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
var C_1;
let C = C_1 = class C {
static x() { return C_1.y; }
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClass8.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
let default_1 = class default_1 {
};
default_1.y = 1;
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClassAccessor1.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
class default_1 {
get accessor() { return 1; }
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClassMethod1.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
class default_1 {
method() { }
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClassMethod13.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
class C {
["1"]() { }
["b"]() { }
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClassMethod4.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
class C {
["method"]() { }
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClassMethod5.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
class C {
["method"]() { }
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClassMethod6.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
class C {
["method"]() { }
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClassMethod7.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let C = /** @class */ (() => {
const C = /** @class */ (() => {
class C {
["method"]() { }
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
var __param = (this && this.__param) || function (paramIndex, decorator) {
return function (target, key) { decorator(target, key, paramIndex); }
};
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
class default_1 {
method(p) { }
}
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/decoratorOnClassProperty1.es6.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let default_1 = /** @class */ (() => {
const default_1 = /** @class */ (() => {
class default_1 {
}
__decorate([
Expand Down
10 changes: 5 additions & 5 deletions tests/baselines/reference/decoratorsOnComputedProperties.js
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ function foo() { return ++i + ""; }
const fieldNameA = "fieldName1";
const fieldNameB = "fieldName2";
const fieldNameC = "fieldName3";
let A = /** @class */ (() => {
const A = /** @class */ (() => {
var _a, _b, _c, _d;
class A {
constructor() {
Expand Down Expand Up @@ -259,7 +259,7 @@ void (_a = class B {
_g = fieldNameB,
_h = fieldNameC,
_a);
let C = /** @class */ (() => {
const C = /** @class */ (() => {
var _a, _b, _c, _d;
class C {
constructor() {
Expand Down Expand Up @@ -309,7 +309,7 @@ void class D {
}
[(foo(), _j = foo(), _k = foo(), _l = fieldNameB, _m = fieldNameC, "some" + "method")]() { }
};
let E = /** @class */ (() => {
const E = /** @class */ (() => {
var _a, _b, _c, _d;
class E {
constructor() {
Expand Down Expand Up @@ -363,7 +363,7 @@ void (_b = class F {
_q = fieldNameB,
_r = fieldNameC,
_b);
let G = /** @class */ (() => {
const G = /** @class */ (() => {
var _a, _b, _c, _d;
class G {
constructor() {
Expand Down Expand Up @@ -418,7 +418,7 @@ void (_c = class H {
},
_v = fieldNameC,
_c);
let I = /** @class */ (() => {
const I = /** @class */ (() => {
var _a, _b, _c, _d, _e;
class I {
constructor() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class B {
}

//// [emitClassDeclarationWithLiteralPropertyNameInES6.js]
let B = /** @class */ (() => {
const B = /** @class */ (() => {
class B {
constructor() {
this["hello"] = 10;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ class D {


//// [emitClassDeclarationWithStaticPropertyAssignmentInES6.js]
let C = /** @class */ (() => {
const C = /** @class */ (() => {
class C {
}
C.z = "Foo";
return C;
})();
let D = /** @class */ (() => {
const D = /** @class */ (() => {
class D {
constructor() {
this.x = 20000;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
define(["require", "exports"], function (require, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
let A = /** @class */ (() => {
const A = /** @class */ (() => {
let A = class A {
};
A = __decorate([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
Object.defineProperty(exports, "__esModule", { value: true });
let A = /** @class */ (() => {
const A = /** @class */ (() => {
let A = class A {
};
A = __decorate([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let A = /** @class */ (() => {
const A = /** @class */ (() => {
let A = class A {
};
A = __decorate([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
return c > 3 && r && Object.defineProperty(target, key, r), r;
};
let A = /** @class */ (() => {
const A = /** @class */ (() => {
let A = class A {
};
A = __decorate([
Expand Down
Loading