Skip to content

Fix the usage of pattern matching in module resolution for check of hasZeroOrOneAsteriskCharacter #35209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2019
Merged

Fix the usage of pattern matching in module resolution for check of hasZeroOrOneAsteriskCharacter #35209

merged 2 commits into from
Nov 20, 2019

Conversation

sheetalkamat
Copy link
Member

Fixes #35171

@sheetalkamat
Copy link
Member Author

@RyanCavanaugh @DanielRosenwasser Do we want this for 3.7 as per #35171 (comment)

DanielRosenwasser
DanielRosenwasser reviewed Nov 19, 2019
View reviewed changes
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Nov 19, 2019 •
edited
Loading

Do we want this for 3.7

Is this a breaking change?

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.7

@typescript-bot typescript-bot mentioned this pull request Nov 19, 2019
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #35213 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 19, 2019
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#35209 into release-3.7
ebdb3ac 
Component commits:
74a6343 Fix the usage of pattern matching for check of hasZeroOrOneAsteriskCharacter Fixes microsoft#35171
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 19, 2019
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#35209 into release-3.7
41635d1 
Component commits:
74a6343 Fix the usage of pattern matching for check of hasZeroOrOneAsteriskCharacter Fixes microsoft#35171
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually.

@sheetalkamat
Copy link
Member Author

Is this a breaking change?

No but with vscode making updateOpen exceptions to close the tsserver it makes project with this configuration to crash LS completely

@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.7

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 19, 2019
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#35209 into release-3.7
91ef673 
Component commits:
74a6343 Fix the usage of pattern matching for check of hasZeroOrOneAsteriskCharacter Fixes microsoft#35171

ffe82c6 Fix error message
@sheetalkamat sheetalkamat merged commit 0e736a7 into master Nov 20, 2019
sheetalkamat pushed a commit that referenced this pull request Nov 20, 2019
@sheetalkamat
Cherry-pick PR #35209 into release-3.7 (#35213)
c18d72f 
Component commits:
74a6343 Fix the usage of pattern matching for check of hasZeroOrOneAsteriskCharacter Fixes #35171

ffe82c6 Fix error message
@sheetalkamat sheetalkamat deleted the pathValidation branch December 11, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@orta orta orta approved these changes

@amcasey amcasey Awaiting requested review from amcasey

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@sandersn sandersn Awaiting requested review from sandersn

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript language service crashes because of wrong setting in tsconfig.json
4 participants
@sheetalkamat @DanielRosenwasser @typescript-bot @orta