Fix Number.is* to accept unknown again #34932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #34931 This essentially reapplies #24436 which incorrectly updated the generated files rather than the sources, and so was wiped out by 2f73986. Note that this is specifically _not_ the same as #4002, which pertains to the global functions that coerce their arguments and therefore should _not_ accept `unknown`. This change was already accepted 18 months ago, but was applied incorrectly.
|
I looked for a test that could be updated but I have no idea what would be appropriate - I found no unit tests that pertained to any of these declarations. If there's something I can update to ensure it sticks this time, please advise. |
|
Time to add new tests! Which brings me to my wishlist. If only there was code coverage for types... Then we'd know how many % of those lib.d.ts files actually have tests |
|
Guys. I'm sorry. But what are you waiting for? Why don't you merge PR? The correct behavior has been broken and needs to be restored. |
|
Cool, checked over the history and these fixes look good IMO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34931
This essentially reapplies #24436 which incorrectly updated the generated files rather than the sources, and so was wiped out by 2f73986.
Note that this is specifically not the same as #4002, which pertains to the global functions that coerce their arguments and therefore should not accept
unknown. This change was already accepted 18 months ago, but was applied incorrectly.