disallow 'await' and 'yield' in property and enum member initializer #34892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elibarzilay
force-pushed
the
awaitInInitializer
branch
from
af21423 to
9cf6486
Compare
rbuckton
approved these changes
Nov 15, 2019
elibarzilay
added a commit
to elibarzilay/TypeScript
that referenced
this pull request
Nov 15, 2019
Also, drop the other cases where they were ignored, since they're forbidden in enums, and the others are fine wrt the comment that was there. Fixes microsoft#34892
elibarzilay
added a commit
to elibarzilay/TypeScript
that referenced
this pull request
Nov 20, 2019
Also, drop the other cases where they were ignored, since they're forbidden in enums, and the others are fine wrt the comment that was there. Fixes microsoft#34892
elibarzilay
added a commit
to elibarzilay/TypeScript
that referenced
this pull request
Nov 21, 2019
Also, drop the other cases where they were ignored, since they're forbidden in enums, and the others are fine wrt the comment that was there. Fixes microsoft#34892
elibarzilay
added a commit
that referenced
this pull request
Nov 22, 2019
Also, drop the other cases where they were ignored, since they're forbidden in enums, and the others are fine wrt the comment that was there. Fixes #34892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34887
Disallows
awaitandyieldin class property initializers.yieldis now allowed in computed names (if you ignoreA computed property name in a class property declaration must refer to an expression whose type is a literal type or a 'unique symbol' type.).Removes some special handling for parsing
yieldin static property initializers. An error was added in Checker anyway.Disallows
awaitandyieldin enum declarations. Since enums are transpiled to IIFEs, they don't inherit the context from the containing function.